All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com
Cc: svt-core@virtuozzo.com, andrey.drobyshev@virtuozzo.com
Subject: Re: [PATCH hci-8.1 v4 3/5] vhost-blk: use a local vhost_dev pointer in start and stop
Date: Thu, 29 Oct 2026 11:04:14 +0100	[thread overview]
Message-ID: <a14199a0-de7d-4d43-9852-f99518a07cbe@virtuozzo.com> (raw)
In-Reply-To: <010701a186fa185c-0055b5f5-c6e0-4cb3-bc54-2a6214472c27-000000@eu-central-1.amazonses.com>

> [Severity: Low]
> The message says "No functional change", yet it carries a Fixes: tag
> pointing at 0ff3cb5ff28f ("block: add vhost-blk backend").
>
> The only edits are the new local alias in vhost_blk_start() and
> vhost_blk_stop():
>
>      struct vhost_dev *hdev = &s->dev;
>
> and the replacement of &s->dev with hdev at each use. Nothing in the diff
> fixes a bug.
>
> Could the Fixes: tag be dropped? Stable-backport tooling may otherwise pick
> up this cosmetic cleanup.
>
> If a real bug is being fixed, could the commit message describe it?
The Fixes: tag is intentional: the maintainer asked for this cleanup to 
be split
out with a Fixes: tag so it can be squashed into 0ff3cb5ff28f on the 
next rebase.

  reply	other threads:[~2026-10-29 10:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  9:22 [PATCH hci-8.1 v4 0/5] vhost-blk: switch from VHOST_SET_NWORKERS to the mainstream worker ioctls Alexander Ivanov
2026-10-29  9:22 ` [PATCH hci-8.1 v4 1/5] vhost-backend: add vhost_set_fork_from_owner op Alexander Ivanov
2026-10-29  9:24   ` no-reply
2026-10-29  9:22 ` [PATCH hci-8.1 v4 2/5] vhost-blk: reject num-queues above VHOST_BLK_MAX_QUEUES Alexander Ivanov
2026-10-29  9:24   ` no-reply
2026-10-29  9:22 ` [PATCH hci-8.1 v4 3/5] vhost-blk: use a local vhost_dev pointer in start and stop Alexander Ivanov
2026-10-29  9:24   ` no-reply
2026-10-29 10:04     ` Alexander Ivanov [this message]
2026-10-29  9:28   ` Andrey Drobyshev
2026-10-29  9:23 ` [PATCH hci-8.1 v4 4/5] vhost-blk: create kernel threads with the mainstream worker ioctls Alexander Ivanov
2026-10-29  9:27   ` no-reply
2026-10-29  9:57     ` Alexander Ivanov
2026-10-29  9:35   ` Andrey Drobyshev
2026-10-29 10:12   ` Andrey Zhadchenko
2026-10-29  9:23 ` [PATCH hci-8.1 v4 5/5] linux-headers: drop VHOST_SET_NWORKERS Alexander Ivanov
2026-10-29  9:25   ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a14199a0-de7d-4d43-9852-f99518a07cbe@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=andrey.drobyshev@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=no-reply@sashiko.virtuozzo.com \
    --cc=svt-core@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.