Re: [QEMU HCI-8.0 PATCH v3 0/4] vhost-blk: improve feature negotiation

[Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>]

On 8/25/26 8:27 PM, Andrey Zhadchenko wrote:
> Feature negotiation in vhost-blk is a bit of a mess:
>  - offering VIRTIO_BLK_F_SIZE_MAX along with size_max == 0 is a
> bug which causes win2012 crashes
>  - kernel not allowed to reject some actually unimplmented
> feature bits
>  - flush is not offered to the guests despite kernel support
>  - duplicate ioctls
> 
> Fix everything above.
> 
> v3:
>  - separated patches per reviewer requests
>  - add new patch dropping extra VHOST_GET_FEATURES ioctl
> 
> Andrey Zhadchenko (4):
>   vhost-blk: never offer VIRTIO_BLK_F_SIZE_MAX
>   vhost-blk: expand list of the features kernel can refuse
>   vhost-blk: offer VIRTIO_BLK_F_FLUSH
>   vhost-blk: drop vhost_dev.backend_features use
> 
>  hw/block/vhost-blk.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 

Fixed my own comment to patch 3 myself.  With that:
Reviewed-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>

Applied to hci-8.0