OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
* [Devel] [PATCH hci-8.1 v2] configs: build with WERROR and KVM_WERROR, as RHEL does
@ 2026-10-27 15:08 Konstantin Khorenko
  2026-10-27 15:11 ` no-reply
  2026-10-27 15:42 ` Konstantin Khorenko
  0 siblings, 2 replies; 3+ messages in thread
From: Konstantin Khorenko @ 2026-10-27 15:08 UTC (permalink / raw)
  To: devel, Konstantin Khorenko

RHEL generates its configs in "make dist-srpm": the redhat/Makefile
dist-* targets export ENABLE_WERROR=1, and build_configs.sh then turns
CONFIG_WERROR, CONFIG_KVM_WERROR and CONFIG_OBJTOOL_WERROR on in every
config.

We call build_configs.sh directly, without ENABLE_WERROR, so the vz
kernel builds without -Werror and a new warning goes unnoticed.

We already have CONFIG_OBJTOOL_WERROR=y due to work on KLP, so set
CONFIG_WERROR and CONFIG_KVM_WERROR in custom-overrides/generic as well.
Like ENABLE_WERROR, they reach every flavor, the debug one included.

The um variant, the User Mode Linux KUnit kernel, does not build with
-Werror yet, so custom-overrides/generic/um/CONFIG_WERROR keeps it off
there.

https://virtuozzo.atlassian.net/browse/VSTOR-151903

Feature: internal
Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
Assisted-by: LLM
---
Changes in v2:
- Name the um layer file that keeps WERROR off, not the generated
  kernel-um-rhel.config, which the kernel tree does not carry.
- Say the overrides reach every flavor, as ENABLE_WERROR does.
- Fix the target name: dist-srpm.
- Link to v1: http://lore.virtuozzo.com/20261027-b4-prep-khorenko-vstor-151903-werror-v1-1-00b3a34049dd@virtuozzo.com
---
 redhat/configs/custom-overrides/generic/CONFIG_KVM_WERROR | 1 +
 redhat/configs/custom-overrides/generic/CONFIG_WERROR     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/redhat/configs/custom-overrides/generic/CONFIG_KVM_WERROR b/redhat/configs/custom-overrides/generic/CONFIG_KVM_WERROR
new file mode 100644
index 0000000000000..af20cbee74354
--- /dev/null
+++ b/redhat/configs/custom-overrides/generic/CONFIG_KVM_WERROR
@@ -0,0 +1 @@
+CONFIG_KVM_WERROR=y
diff --git a/redhat/configs/custom-overrides/generic/CONFIG_WERROR b/redhat/configs/custom-overrides/generic/CONFIG_WERROR
new file mode 100644
index 0000000000000..f54ff6cdaab85
--- /dev/null
+++ b/redhat/configs/custom-overrides/generic/CONFIG_WERROR
@@ -0,0 +1 @@
+CONFIG_WERROR=y

---
base-commit: 39277db2080bec85a02c245ac0d7d185b37cdfdd
change-id: 20261027-b4-prep-khorenko-vstor-151903-werror-33b973335ad5

Best regards,
--  
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Devel] [PATCH hci-8.1 v2] configs: build with WERROR and KVM_WERROR, as RHEL does
  2026-10-27 15:08 [Devel] [PATCH hci-8.1 v2] configs: build with WERROR and KVM_WERROR, as RHEL does Konstantin Khorenko
@ 2026-10-27 15:11 ` no-reply
  2026-10-27 15:42 ` Konstantin Khorenko
  1 sibling, 0 replies; 3+ messages in thread
From: no-reply @ 2026-10-27 15:11 UTC (permalink / raw)
  To: devel, Konstantin Khorenko

> RHEL generates its configs in "make dist-srpm": the redhat/Makefile
> dist-* targets export ENABLE_WERROR=1, and build_configs.sh then turns
> CONFIG_WERROR, CONFIG_KVM_WERROR and CONFIG_OBJTOOL_WERROR on in every
> config.
> 
> We call build_configs.sh directly, without ENABLE_WERROR, so the vz
> kernel builds without -Werror and a new warning goes unnoticed.
> 
> We already have CONFIG_OBJTOOL_WERROR=y due to work on KLP, so set
> CONFIG_WERROR and CONFIG_KVM_WERROR in custom-overrides/generic as well.
> Like ENABLE_WERROR, they reach every flavor, the debug one included.
> 
> The um variant, the User Mode Linux KUnit kernel, does not build with
> -Werror yet, so custom-overrides/generic/um/CONFIG_WERROR keeps it off
> there.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-151903
> 
> Feature: internal
> Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261027-b4-prep-khorenko-vstor-151903-werror-v2-1-b77e17cc3b3d@virtuozzo.com?part=1


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Devel] [PATCH hci-8.1 v2] configs: build with WERROR and KVM_WERROR, as RHEL does
  2026-10-27 15:08 [Devel] [PATCH hci-8.1 v2] configs: build with WERROR and KVM_WERROR, as RHEL does Konstantin Khorenko
  2026-10-27 15:11 ` no-reply
@ 2026-10-27 15:42 ` Konstantin Khorenko
  1 sibling, 0 replies; 3+ messages in thread
From: Konstantin Khorenko @ 2026-10-27 15:42 UTC (permalink / raw)
  To: devel, Konstantin Khorenko

On Tue, 27 Oct 2026 16:08:15 +0100, Konstantin Khorenko wrote:
> configs: build with WERROR and KVM_WERROR, as RHEL does

Applied to branch-rh10-6.12.0-211.52.1.22.x.vz10-ovz, will be released in rh10-6.12.0-211.52.1.22.11.vz10, thanks!

[1/1] configs: build with WERROR and KVM_WERROR, as RHEL does
      https://bitbucket.org/virtuozzocore/vzkernel.vzs/commits/02401c5e378f

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-27 15:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-27 15:08 [Devel] [PATCH hci-8.1 v2] configs: build with WERROR and KVM_WERROR, as RHEL does Konstantin Khorenko
2026-10-27 15:11 ` no-reply
2026-10-27 15:42 ` Konstantin Khorenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox