OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
	Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 1/2] fs/aio: restore the AIO ring of the dumped size in a pseudosuper VE
Date: Fri, 13 Nov 2026 15:14:17 +0000	[thread overview]
Message-ID: <010701a1d5794777-9767deb9-3190-4977-aa51-8afdd0ecfd23-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-1-7d35d143fdc3@virtuozzo.com>

> io_setup() makes the ring at least 4 events per possible CPU of the
> node. The ring is mapped into the task memory, and CRIU restores it with
> io_setup() and moves the new mapping to the address of the old one, so
> it needs a ring of the same size. On a node with more possible CPUs it
> gets a bigger ring, and the restore fails. E.g. io_setup(1) makes a
> ring of one page, 127 events, on 4 CPUs, and of two pages, 255 events,
> on 16 CPUs.
> 
> Skip the CPU heuristic while the VE is pseudosuper, which it is only for
> the restore. Keep the other adjustments, the doubling and the rounding
> up to pages: they don't depend on the node, and the queue depth CRIU
> estimates from the dumped ring already offsets them, so the restore gets
> the ring of the dumped size.
> 
> After a migration to a node with more possible CPUs an AIO context can
> be slightly less reliable: io_submit() can return EAGAIN before the ring
> is full, while free slots sit in the per-CPU caches of other CPUs.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-154129
> 
> Feature: ve: CRIU support
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-0-7d35d143fdc3@virtuozzo.com?part=1


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-13 15:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 15:08 [Devel] [PATCH hci-8.1 0/2] fs/aio: fix CT migration with AIO to a node with more CPUs Pavel Tikhomirov
2026-11-13 15:08 ` [Devel] [PATCH hci-8.1 1/2] fs/aio: restore the AIO ring of the dumped size in a pseudosuper VE Pavel Tikhomirov
2026-11-13 15:14   ` no-reply [this message]
2026-11-13 19:41   ` Konstantin Khorenko
2026-11-13 15:08 ` [Devel] [PATCH hci-8.1 2/2] selftests/ve: check the AIO ring " Pavel Tikhomirov
2026-11-13 15:15   ` no-reply
2026-11-13 19:41   ` Konstantin Khorenko
2026-11-13 19:41 ` [Devel] [PATCH hci-8.1 0/2] fs/aio: fix CT migration with AIO to a node with more CPUs Konstantin Khorenko
2026-11-16 10:33   ` Pavel Tikhomirov
2026-11-16 10:35     ` Pavel Tikhomirov
2026-11-16 10:35   ` Pavel Tikhomirov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1d5794777-9767deb9-3190-4977-aa51-8afdd0ecfd23-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    --cc=ptikhomirov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox