OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 0/2] fs/aio: fix CT migration with AIO to a node with more CPUs
Date: Fri, 13 Nov 2026 20:41:41 +0100	[thread overview]
Message-ID: <179459890134.57567.3765669749365305224.b4-review@b4> (raw)
In-Reply-To: <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-0-7d35d143fdc3@virtuozzo.com>

I won't apply this version, please send v2 with the changes below.

On Fri, 13 Nov 2026 16:08:43 +0100, Pavel Tikhomirov wrote:
> Pavel Tikhomirov (2):
>       fs/aio: restore the AIO ring of the dumped size in a pseudosuper VE
>       selftests/ve: check the AIO ring size in a pseudosuper VE

The ring sizing is right: with the CPU heuristic skipped, CRIU's
(nr - 2) / 2 gets back the dumped ring for any page count and CPU
counts, and the host, running CTs and restores to a node with fewer
CPUs are unchanged. What to change for v2:

1. Patch 1, code: a restored ring below this node's minimum must not
   lose slots in the per-CPU caches. E.g. mark such a context in
   ioctx_alloc() and let put_reqs_available() and
   __get_reqs_available() use ctx->reqs_available directly for it.
   If you keep the cache, the commit message must state the real
   bound instead of "slightly less reliable".

2. Patch 1, commit message and comment: the VE is pseudosuper not only
   for the restore. vzctl sets ve.pseudosuper on every CT start and
   clears it just before it execs init. Say "while the CT is being
   started or restored", or similar.

3. Patch 1, commit message: say what fails without the patch: CRIU's
   restore_aio_ring() reports "wrong aio" and the migration is
   aborted.

4. Patch 2: read the CPU count from /sys/devices/system/cpu/possible,
   the mask the kernel uses, not sysconf(_SC_NPROCESSORS_CONF).

5. Patch 2: do not leave the VE cgroup behind when FIXTURE_SETUP fails
   after make_ve(), and use ASSERT_EQ for set_pseudosuper().

Separate patches, not needed for v2 (I created a task):

1. vz misses mainline b44341e39d856 ("aio: avoid request count
   overflow in ioctx_alloc()"), which touches the lines next to
   patch 1.
   https://virtuozzo.atlassian.net/browse/VSTOR-155110

Details are in the replies to the patches.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-13 19:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 15:08 Pavel Tikhomirov
2026-11-13 15:08 ` [Devel] [PATCH hci-8.1 1/2] fs/aio: restore the AIO ring of the dumped size in a pseudosuper VE Pavel Tikhomirov
2026-11-13 15:14   ` no-reply
2026-11-13 19:41   ` Konstantin Khorenko
2026-11-13 15:08 ` [Devel] [PATCH hci-8.1 2/2] selftests/ve: check the AIO ring " Pavel Tikhomirov
2026-11-13 15:15   ` no-reply
2026-11-13 19:41   ` Konstantin Khorenko
2026-11-13 19:41 ` Konstantin Khorenko [this message]
2026-11-16 10:33   ` [Devel] [PATCH hci-8.1 0/2] fs/aio: fix CT migration with AIO to a node with more CPUs Pavel Tikhomirov
2026-11-16 10:35     ` Pavel Tikhomirov
2026-11-16 10:35   ` Pavel Tikhomirov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179459890134.57567.3765669749365305224.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=ptikhomirov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox