OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 05/10] ms/mptcp: close TOCTOU race while computing rcv_wnd
Date: Mon, 16 Nov 2026 03:59:41 +0000	[thread overview]
Message-ID: <010701a1e282bc24-38644be9-3f76-4575-85e7-dcaccd4e1f03-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116035204.564416-6-eva.kurchatova@virtuozzo.com>

> From: Paolo Abeni <pabeni@redhat.com>
> 
> The MPTCP output path access locklessly the MPTCP-level ack_seq
> in multiple times, using possibly different values for the data_ack
> in the DSS option and to compute the announced rcv wnd for the same
> packet.
> 
> Refactor the cote to avoid inconsistencies which may confuse the
> peer. Also ensure that the MPTCP level rcv wnd is updated only when
> the egress packet actually contains a DSS ack.
> 
> Fixes: fa3fe2b15031 ("mptcp: track window announced to peer")
> Cc: stable@vger.kernel.org
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Link: https://patch.msgid.link/20260602-net-mptcp-misc-fixes-7-1-rc7-v2-3-856831229976@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> (cherry picked from commit 8ab24fdebc369c0dfb90f82c1650b1e66662bb45)
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-153491
> Feature: fix ms/net
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116035204.564416-1-eva.kurchatova@virtuozzo.com?part=5


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-16  4:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  3:49 [Devel] [PATCH hci-8.1 v2 00/10] ms/mptcp: stability fixes Eva Kurchatova
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 01/10] ms/mptcp: fix retransmission loop when csum is enabled Eva Kurchatova
2026-11-16  3:58   ` no-reply
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 02/10] ms/mptcp: move the retrans loop to a separate helper Eva Kurchatova
2026-11-16  3:55   ` no-reply
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 03/10] ms/mptcp: move the stale logic out of retrans scheduler Eva Kurchatova
2026-11-16  3:56   ` no-reply
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 04/10] ms/mptcp: let the retrans scheduler do its job Eva Kurchatova
2026-11-16  3:59   ` no-reply
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 05/10] ms/mptcp: close TOCTOU race while computing rcv_wnd Eva Kurchatova
2026-11-16  3:59   ` no-reply [this message]
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 06/10] ms/mptcp: allow subflow rcv wnd to shrink Eva Kurchatova
2026-11-16  4:02   ` no-reply
2026-11-16 17:09   ` Konstantin Khorenko
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 07/10] ms/mptcp: explicitly drop over memory limits Eva Kurchatova
2026-11-16  4:03   ` no-reply
2026-11-16 17:09   ` Konstantin Khorenko
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 08/10] ms/mptcp: implemented OoO queue pruning Eva Kurchatova
2026-11-16  4:04   ` no-reply
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 09/10] ms/mptcp: being below memory limit is a likely() condition Eva Kurchatova
2026-11-16  4:03   ` no-reply
2026-11-16  3:49 ` [Devel] [PATCH hci-8.1 v2 10/10] ms/mptcp: avoid pruning for OoW data Eva Kurchatova
2026-11-16  4:04   ` no-reply
2026-11-16 17:09 ` [Devel] [PATCH hci-8.1 v2 00/10] ms/mptcp: stability fixes Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1e282bc24-38644be9-3f76-4575-85e7-dcaccd4e1f03-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox