From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 00/10] ms/mptcp: stability fixes
Date: Mon, 16 Nov 2026 18:09:04 +0100 [thread overview]
Message-ID: <179484894400.861498.16940306217017869314.b4-review@b4> (raw)
In-Reply-To: <20261116035204.564416-1-eva.kurchatova@virtuozzo.com>
I won't apply this version, please send v3 with the changes below.
On Mon, 16 Nov 2026 05:49:07 +0200, Eva Kurchatova <eva.kurchatova@virtuozzo.com> wrote:
> Changes in v2:
> - Add "ms/mptcp: close TOCTOU race while computing rcv_wnd" and
> "ms/mptcp: allow subflow rcv wnd to shrink before the drop over memory
> limits".
The backports match mainline and the rebase notes are accurate. What
to change for v3:
1. Add mainline 2834f8edd74d5 ("mptcp: cleanup fallback dummy mapping
generation") before patch 7. Without it, a drop by patch 7 followed
by a fallback to TCP silently cuts bytes out of the stream.
2. Patch 6: say in a rebase note that mainline 0e24d17bd9668 ("tcp:
implement RFC 7323 window retraction receiver requirements"), which
it sits on in mainline, is not taken, as in 6.12.y.
3. Cover letter: item 2 of my v1 reply is still open. Say what the
series fixes (endless retransmission with csum, receive stalls
under memory pressure), which patches are only prerequisites, what
was left out of the mainline series and why, and how it was tested.
Also bring back the Jira link, name the base of the rebase, and
close the quote after "allow subflow rcv wnd to shrink".
Separate patches, not needed for v3; I created a task for each:
1. Already in the base: when sk_rmem_schedule() fails in
__mptcp_move_skb() (tcp_mem limit, memcg charge in a container),
TCP-acked data is dropped even on a fallback socket, and the next
bytes take its place in the stream. Mainline removed that drop with
9db5b3cec4ec ("mptcp: borrow forward memory from subflow").
https://virtuozzo.atlassian.net/browse/VSTOR-155321
2. Four Cc stable mptcp fixes this tree lacks: 42064de57fb83,
f3ef03357396d, 85c580b0d8590, 0981f90e1a05.
https://virtuozzo.atlassian.net/browse/VSTOR-155322
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-11-16 17:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 3:49 Eva Kurchatova
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 01/10] ms/mptcp: fix retransmission loop when csum is enabled Eva Kurchatova
2026-11-16 3:58 ` no-reply
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 02/10] ms/mptcp: move the retrans loop to a separate helper Eva Kurchatova
2026-11-16 3:55 ` no-reply
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 03/10] ms/mptcp: move the stale logic out of retrans scheduler Eva Kurchatova
2026-11-16 3:56 ` no-reply
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 04/10] ms/mptcp: let the retrans scheduler do its job Eva Kurchatova
2026-11-16 3:59 ` no-reply
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 05/10] ms/mptcp: close TOCTOU race while computing rcv_wnd Eva Kurchatova
2026-11-16 3:59 ` no-reply
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 06/10] ms/mptcp: allow subflow rcv wnd to shrink Eva Kurchatova
2026-11-16 4:02 ` no-reply
2026-11-16 17:09 ` Konstantin Khorenko
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 07/10] ms/mptcp: explicitly drop over memory limits Eva Kurchatova
2026-11-16 4:03 ` no-reply
2026-11-16 17:09 ` Konstantin Khorenko
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 08/10] ms/mptcp: implemented OoO queue pruning Eva Kurchatova
2026-11-16 4:04 ` no-reply
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 09/10] ms/mptcp: being below memory limit is a likely() condition Eva Kurchatova
2026-11-16 4:03 ` no-reply
2026-11-16 3:49 ` [Devel] [PATCH hci-8.1 v2 10/10] ms/mptcp: avoid pruning for OoW data Eva Kurchatova
2026-11-16 4:04 ` no-reply
2026-11-16 17:09 ` Konstantin Khorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179484894400.861498.16940306217017869314.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox