From: no-reply@sashiko.virtuozzo.com
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] drivers/md/dm-qcow2: set header_length to 72 for v2 images
Date: Mon, 16 Nov 2026 10:08:54 +0000 [thread overview]
Message-ID: <010701a1e3d4c696-5cfa02d6-568e-4594-a999-2ae7d597568e-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116100522.2867539-1-alexander.ivanov@virtuozzo.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dm-qcow2: bug-fix commit lacks a Fixes: trailer
--
commit 50d27ce56be53596fa9d5de781a9cec9b705d815
Author: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> drivers/md/dm-qcow2: set header_length to 72 for v2 images
>
> qcow2_check_convert_hdr() returns for a v2 image before it fills in
> hdr->header_length, so the field stays 0 from kzalloc().
> qcow2_parse_header() uses header_length as the start of header
> extensions and so parses them from offset 0 of the image, i.e. from
> the header itself, instead of from offset 72 right after the v2 header.
>
> Set header_length to the size of the v2 header before the version
> check, as qemu does. v3 images overwrite it from the raw header.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-152394
> Feature: dm-qcow2: block device over QCOW2 files driver
>
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
[Severity: Low]
This fixes a bug that has been there since the driver was introduced: the
early return for v2 images has always left header_length at 0. Should this
include:
Fixes: 2a728299abdb ("dm-qcow2: Introduce driver to create block devices over QCOW2 files")
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116100522.2867539-1-alexander.ivanov@virtuozzo.com?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 10:05 Alexander Ivanov
2026-11-16 10:08 ` no-reply [this message]
2026-11-16 17:19 ` Konstantin Khorenko
2026-11-16 17:20 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1e3d4c696-5cfa02d6-568e-4594-a999-2ae7d597568e-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox