From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] drivers/md/dm-qcow2: set header_length to 72 for v2 images
Date: Mon, 16 Nov 2026 18:19:54 +0100 [thread overview]
Message-ID: <179484959467.861498.10599182174861519391.b4-review@b4> (raw)
In-Reply-To: <20261116100522.2867539-1-alexander.ivanov@virtuozzo.com>
Applying with these fixes on my side:
- subject prefix "drivers/md/dm-qcow2:" -> "dm-qcow2:", as in your
sibling patch and most of the driver history
- added what the bug did: the walk ends on a zero word of the header,
so v2 extensions were never seen
- added the new behaviour: a bitmaps extension in a v2 image is now
checked as on v3, and a malformed one fails the table load, while
qemu warns and ignores it
- added Fixes: f625cc9e0c22 ("dm-qcow2: parse bitmap extension"),
which brought ext_start = hdr->header_length; 2a728299abdb, which
Sashiko named, never read header_length for v2
On Mon, 16 Nov 2026 11:05:22 +0100, Alexander Ivanov wrote:
> Set header_length to the size of the v2 header before the version
> check, as qemu does. v3 images overwrite it from the raw header.
Bitmaps need the autoclear bit, which only v3 has, so a v2 image with
a bitmaps extension is not valid anyway. The stricter check is fine
with me, no code change needed.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 10:05 Alexander Ivanov
2026-11-16 10:08 ` no-reply
2026-11-16 17:19 ` Konstantin Khorenko [this message]
2026-11-16 17:20 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179484959467.861498.10599182174861519391.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox