OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
	andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] dm-qcow2: reject v3 images with header_length below 104
Date: Mon, 16 Nov 2026 10:40:47 +0000	[thread overview]
Message-ID: <010701a1e3f1f75c-8ca0aaca-3a24-445c-b4aa-4424b955634e-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116103752.2878746-1-alexander.ivanov@virtuozzo.com>

> qcow2_check_convert_hdr() checks header_length only when the
> compression bit is set, and only against sizeof(struct QCowHeader). A
> v3 image with header_length below the fixed v3 header size is
> accepted, and the header extension parser then starts at
> header_length and reads the fixed header fields as extensions.
> 
> The driver used to refuse such images, but the check went under the
> compression bit when zstd support was added.
> 
> Fail with -EINVAL when a v3 image has header_length below 104,
> regardless of its incompatible features, as qemu does ("qcow2 header
> too short").
> 
> Fixes: 66195f78dd3c ("dm-qcow2: add zstd decompression")
> https://virtuozzo.atlassian.net/browse/VSTOR-152393
> Feature: dm-qcow2: block device over QCOW2 files driver
> 
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116103752.2878746-1-alexander.ivanov@virtuozzo.com?part=1


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-16 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:37 Alexander Ivanov
2026-11-16 10:40 ` no-reply [this message]
2026-11-16 17:21 ` Konstantin Khorenko
2026-11-16 17:21 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1e3f1f75c-8ca0aaca-3a24-445c-b4aa-4424b955634e-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=alexander.ivanov@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox