From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: [Devel] [PATCH hci-8.1] dm-qcow2: reject v3 images with header_length below 104
Date: Mon, 16 Nov 2026 11:37:52 +0100 [thread overview]
Message-ID: <20261116103752.2878746-1-alexander.ivanov@virtuozzo.com> (raw)
qcow2_check_convert_hdr() checks header_length only when the
compression bit is set, and only against sizeof(struct QCowHeader). A
v3 image with header_length below the fixed v3 header size is
accepted, and the header extension parser then starts at
header_length and reads the fixed header fields as extensions.
The driver used to refuse such images, but the check went under the
compression bit when zstd support was added.
Fail with -EINVAL when a v3 image has header_length below 104,
regardless of its incompatible features, as qemu does ("qcow2 header
too short").
Fixes: 66195f78dd3c ("dm-qcow2: add zstd decompression")
https://virtuozzo.atlassian.net/browse/VSTOR-152393
Feature: dm-qcow2: block device over QCOW2 files driver
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
drivers/md/dm-qcow2-target.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c
index f4004f6095a7..89c3a91f0fec 100644
--- a/drivers/md/dm-qcow2-target.c
+++ b/drivers/md/dm-qcow2-target.c
@@ -612,6 +612,9 @@ static int qcow2_check_convert_hdr(struct dm_target *ti,
hdr->refcount_order = be32_to_cpu(raw_hdr->refcount_order);
hdr->header_length = be32_to_cpu(raw_hdr->header_length);
+ if (hdr->header_length < offsetof(struct QCowHeader, compression_type))
+ return -EINVAL;
+
is_ro = !(dm_table_get_mode(ti->table) & FMODE_WRITE);
// if (!is_ro && kernel_sets_dirty_bit !=
--
2.53.0
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next reply other threads:[~2026-11-16 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 10:37 Alexander Ivanov [this message]
2026-11-16 10:40 ` no-reply
2026-11-16 17:21 ` Konstantin Khorenko
2026-11-16 17:21 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116103752.2878746-1-alexander.ivanov@virtuozzo.com \
--to=alexander.ivanov@virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox