OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] ms/tracefs: fix a leak in eventfs_create_events_dir()
Date: Tue, 17 Nov 2026 05:55:05 +0000	[thread overview]
Message-ID: <010701a1e812c113-b282fd1a-2a58-4655-8b5b-14ef55346c78-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261117055049.810192-1-eva.kurchatova@virtuozzo.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] Fixes trailer lacks parentheses around the quoted subject
--

commit 19e003c422eeb3e947b70fcf695dd6a60f9073e4
Author: Al Viro <viro@zeniv.linux.org.uk>

ms/tracefs: fix a leak in eventfs_create_events_dir()

This commit moves the tracefs_start_creating() call in eventfs_create_events_dir() to after the security_locked_down(LOCKDOWN_TRACEFS) check. A lockdown bail-out then no longer leaves the parent directory locked.

> ms/tracefs: fix a leak in eventfs_create_events_dir()
>
> [ Upstream commit 798a401660a151633cb171738a72a8f1efb9b0b4 ]
>
> If we have LOCKDOWN_TRACEFS, the function bails out - *after*
> having locked the parent directory and without bothering to
> undo that.  Just check it before tracefs_start_creating()...
>
> Fixes: e24709454c45 "tracefs/eventfs: Add missing lockdown checks"
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> (cherry picked from commit 3bcb274a192fc89a003a7808a877faf1f9a81ce3)
>
> https://virtuozzo.atlassian.net/browse/VSTOR-155413
> Feature: fix ms/tracefs
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

[Severity: Low]
This isn't a functional problem, but the Fixes: trailer is malformed. The subject is not enclosed in parentheses, so Fixes-parsing tooling may not recognise it. Should it read:

  Fixes: e24709454c45 ("tracefs/eventfs: Add missing lockdown checks")

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261117055049.810192-1-eva.kurchatova@virtuozzo.com?part=1

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-17  5:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:50 Eva Kurchatova
2026-11-17  5:55 ` no-reply [this message]
2026-11-17  6:02   ` Eva Kurchatova (Virtuozzo)
2026-11-17 15:16 ` Konstantin Khorenko
2026-11-17 15:16 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1e812c113-b282fd1a-2a58-4655-8b5b-14ef55346c78-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox