OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] ms/tracefs: fix a leak in eventfs_create_events_dir()
Date: Tue, 17 Nov 2026 16:16:24 +0100	[thread overview]
Message-ID: <179492858457.994824.7876765289087346628.b4-review@b4> (raw)
In-Reply-To: <20261117055049.810192-1-eva.kurchatova@virtuozzo.com>

Applying as is.

On Tue, 17 Nov 2026 07:50:39 +0200, Eva Kurchatova wrote:
> If we have LOCKDOWN_TRACEFS, the function bails out - *after*
> having locked the parent directory and without bothering to
> undo that.  Just check it before tracefs_start_creating()...

The backport is the 6.12.y commit as is, and the leak is in our tree.

Separate patches, not needed for this one:

1. The other fix of VSTOR-155413, 14f7f52629d91 ("tracefs: Fix
   default permissions not being applied on initial mount"), is still
   missing: tracefs_fill_super() does not apply the mount options, so
   the tracefs root comes up 0755 instead of 0700. Please send it too.
   https://virtuozzo.atlassian.net/browse/VSTOR-155413

2. Same in mainline: on lockdown eventfs_create_events_dir() returns
   NULL, create_event_toplevel_files() checks only IS_ERR(), and
   removing that instance calls eventfs_remove_events_dir(NULL), which
   dereferences it in get_root_inode(). Before this patch the case hung
   on the leaked lock, now rmdir oopses. It needs root and a lockdown
   change racing with the instance creation. To be fixed upstream
   first, I created a task for it:
   https://virtuozzo.atlassian.net/browse/VSTOR-155526

Thanks.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-17 15:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:50 Eva Kurchatova
2026-11-17  5:55 ` no-reply
2026-11-17  6:02   ` Eva Kurchatova (Virtuozzo)
2026-11-17 15:16 ` Konstantin Khorenko [this message]
2026-11-17 15:16 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179492858457.994824.7876765289087346628.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox