From: no-reply@sashiko.virtuozzo.com
To: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>,
khorenko@virtuozzo.com, ptikhomirov@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.2 v2 3/6] ve: hide the tasks that set up a starting VE from the rest of it
Date: Tue, 17 Nov 2026 10:27:39 +0000 [thread overview]
Message-ID: <010701a1e90c4a3f-c2e9901a-f118-42e3-b73c-5356dd2ea5af-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261117101329.225854-4-mirian.shilakadze@virtuozzo.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ve: stale raw VD_VE_SETUP_TASK mark survives a VE change and
acts as a setup mark
--
commit e0d51d916ebfeeef972b7b6efe4a3cba6fd46f27
Author: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
ve: hide the tasks that set up a starting VE from the rest of it
The commit marks a task the host sends into a starting VE as VD_VE_SETUP_TASK. While the VE is pseudosuper, such a task dumps no core and is reachable only from other setup tasks of that VE. Once pseudosuper is cleared, the mark counts as VD_PTRACE_COREDUMP.
> diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c
> --- a/kernel/ve/ve.c
> +++ b/kernel/ve/ve.c
[ ... ]
> +static bool ve_current_has_mark(struct ve_struct *ve, unsigned int mark)
> +{
> + struct mm_struct *mm = current->mm;
> +
> + return ve->is_pseudosuper && task_ve(current) == ve &&
> + mm && mm->vps_dumpable == mark;
> +}
[ ... ]
> + if (task->mm && old_ve != ve &&
> + (ve_is_super(old_ve) ||
> + ve_vps_dumpable(task->mm, old_ve) == VD_VE_SETUP_TASK))
> + task->mm->vps_dumpable = ve->state == VE_STATE_STARTING ?
> + VD_VE_SETUP_TASK : VD_VE_ENTER_TASK;
[Severity: Low]
Can a stale raw VD_VE_SETUP_TASK mark survive a VE change and be treated as a setup mark again?
ve_setup_task() tests the effective value from ve_vps_dumpable(). Once old_ve has left pseudosuper, that value is VD_PTRACE_COREDUMP, so the condition is false. The raw mm->vps_dumpable is then neither rewritten nor cleared.
Suppose a setup task of VE A stays there after A leaves pseudosuper, and is later moved into a different starting pseudosuper VE B. ve_current_has_mark() and ve_vps_dumpable() read the raw mm->vps_dumpable. The task therefore counts as a setup task of B, with the pseudosuper relaxations and ptrace reachability among B's setup tasks. The commit message says a task coming from a container never gets this.
Would clearing or normalizing the raw mark to VD_PTRACE_COREDUMP when the effective value is no longer VD_VE_SETUP_TASK fix this?
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261117101329.225854-1-mirian.shilakadze@virtuozzo.com?part=3
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-17 10:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:13 [Devel] [PATCH hci-8.2 v2 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE Mirian Shilakadze
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 1/6] ve: tell ve_setup_task() which VE the task comes from Mirian Shilakadze
2026-11-17 10:20 ` no-reply
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 2/6] ve: hide only the tasks the host sends into a VE Mirian Shilakadze
2026-11-17 10:22 ` no-reply
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 3/6] ve: hide the tasks that set up a starting VE from the rest of it Mirian Shilakadze
2026-11-17 10:27 ` no-reply [this message]
2026-11-17 11:40 ` Konstantin Khorenko
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 4/6] cgroup: give the CT root file writes and hidden roots only to setup tasks Mirian Shilakadze
2026-11-17 10:30 ` no-reply
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 5/6] fs: keep the mount relaxations of a pseudosuper VE from container binaries Mirian Shilakadze
2026-11-17 10:33 ` no-reply
2026-11-17 11:40 ` Konstantin Khorenko
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 6/6] ve: give the remaining pseudosuper relaxations only to setup tasks Mirian Shilakadze
2026-11-17 10:35 ` no-reply
2026-11-17 11:40 ` [Devel] [PATCH hci-8.2 v2 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1e90c4a3f-c2e9901a-f118-42e3-b73c-5356dd2ea5af-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=mirian.shilakadze@virtuozzo.com \
--cc=ptikhomirov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox