From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.2 v2 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE
Date: Tue, 17 Nov 2026 12:40:25 +0100 [thread overview]
Message-ID: <179491562519.122512.7751819793782686092.b4-review@b4> (raw)
In-Reply-To: <20261117101329.225854-1-mirian.shilakadze@virtuozzo.com>
I won't apply this version, please send v3 with the changes below.
On Tue, 17 Nov 2026 14:13:20 +0400, Mirian Shilakadze wrote:
> This series marks the tasks the host sends into a starting VE as setup
> tasks. Fork keeps the mark, exec drops it, and only a task coming from
> the host gets it.
All seven v1 items are done, and the 1/6 reordering of ve_setup_task()
and the namespace put is right. What is left:
1. Patch 3, code: a host task that entered a starting VE and moves on
to a running VE only after the first one cleared pseudosuper is no
longer hidden there. ve_vps_dumpable(mm, old_ve) is then
VD_PTRACE_COREDUMP, so nothing marks the mm, and the root of the
running VE can read the task's fds. Before the series it got
VD_VE_ENTER_TASK. Your test hops before the clear. Either close it
or say in the 3/6 message that this case is not covered and why.
2. Patch 5, code: ve_try_reserve_mount() still checks ve_is_super(ve)
in front of ve_current_is_host_task(), which is already true for
ve0, and the comment below still says "pseudosuper cases" (Sashiko
asked too).
3. Small text fixes: the second paragraph of the 3/6 message has five
sentences, put the new one about tasks leaving a pseudosuper VE in
its own; "one have to be" -> "one has to be" in the 4/6 comment;
"ve0 never leaves it" in the ve_vps_dumpable() kernel-doc reads as
the opposite of what the code does with ve0.
4. Cover letter change log: "a task that setns()es into its own VE
keeps its mark" is not new, v1 kept it too.
Thanks.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-11-17 11:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:13 Mirian Shilakadze
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 1/6] ve: tell ve_setup_task() which VE the task comes from Mirian Shilakadze
2026-11-17 10:20 ` no-reply
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 2/6] ve: hide only the tasks the host sends into a VE Mirian Shilakadze
2026-11-17 10:22 ` no-reply
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 3/6] ve: hide the tasks that set up a starting VE from the rest of it Mirian Shilakadze
2026-11-17 10:27 ` no-reply
2026-11-17 11:40 ` Konstantin Khorenko
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 4/6] cgroup: give the CT root file writes and hidden roots only to setup tasks Mirian Shilakadze
2026-11-17 10:30 ` no-reply
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 5/6] fs: keep the mount relaxations of a pseudosuper VE from container binaries Mirian Shilakadze
2026-11-17 10:33 ` no-reply
2026-11-17 11:40 ` Konstantin Khorenko
2026-11-17 10:13 ` [Devel] [PATCH hci-8.2 v2 6/6] ve: give the remaining pseudosuper relaxations only to setup tasks Mirian Shilakadze
2026-11-17 10:35 ` no-reply
2026-11-17 11:40 ` Konstantin Khorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179491562519.122512.7751819793782686092.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=mirian.shilakadze@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox