From: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
Subject: Re: [Devel] [PATCH vz10] selftests: livepatch: do not require a kernel build tree to run
Date: Mon, 24 Aug 2026 07:54:58 +0000 [thread overview]
Message-ID: <178755809816.184044.17563652020953853473.b4-review@b4> (raw)
In-Reply-To: <20260821150254.791935-1-eva.kurchatova@virtuozzo.com>
On Fri, 21 Aug 2026 18:02:51 +0300, Eva Kurchatova <eva.kurchatova@virtuozzo.com> wrote:
> setup_config() calls has_kdir(), which skips every livepatch test when
> /lib/modules/$(uname -r)/build is missing. The tests do not compile
> anything though, they insmod the pre-built modules from test_modules/,
> so the check tests a proxy rather than the thing it cares about.
>
> That proxy holds only for a source tree or a machine with kernel-devel
> installed. A packaged testsuite ships the modules pre-built and runs on
> machines with no kernel build tree at all, and there every single test
> reports "ok ... # SKIP". A harness that looks for "not ok" then reports
> the suite as passed, so the whole suite silently tests nothing.
>
> [...]
Reviewed-by: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
--
Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
next prev parent reply other threads:[~2026-08-24 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 15:02 Eva Kurchatova
2026-08-24 7:54 ` Vasileios Almpanis [this message]
2026-08-24 10:40 ` [Devel] [PATCH RHEL10 COMMIT] selftests/livepatch: " Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178755809816.184044.17563652020953853473.b4-review@b4 \
--to=vasileios.almpanis@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox