From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 6/6] net/ip6_vti: fix host panics on a vti6 tunnel moved into a CT
Date: Thu, 12 Nov 2026 14:01:35 +0100 [thread overview]
Message-ID: <179448849599.4060562.16427190740606014474.b4-review@b4> (raw)
In-Reply-To: <20261110163130.2776687-7-den@openvz.org>
Applying with these fixes on my side:
- "container root deletes the tunnel or issues a tunnel ioctl on it" ->
"container root deletes the tunnel, when any process in the
container issues a tunnel ioctl on it (SIOCGETTUNNEL needs no
capability)"
- dropped "SIOCADDTUNNEL on such a device also walks the NULL hash in
vti6_locate()."
- added after "ip link del" keeps working: "A tunnel moved between two
host netns now has its ioctls served in the creation netns too, so
SIOCADDTUNNEL on it creates the new tunnel there, as for ip6tnl and
sit."
- the Jira URL moved next to the Fixes tag, a blank line before
Feature
On Tue, 10 Nov 2026 17:31:30 +0100, Denis V. Lunev wrote:
> ip6n->fb_tnl_dev, so the node panics on a NULL pointer dereference when
> container root deletes the tunnel or issues a tunnel ioctl on it, when
dev_ioctl() passes SIOCDEVPRIVATE commands to the driver without a
capability check, and SIOCGETTUNNEL has none in vti6_siocdevprivate()
either. Any process in the CT could panic the node, not only root.
> unloaded. SIOCADDTUNNEL on such a device also walks the NULL hash in
> vti6_locate().
Not after 4/6: the ADD path now reads ip6n->fb_tnl_dev first and faults
there, before vti6_locate().
> change. For a moved one the CAP_NET_ADMIN checks of the ioctls now run
> against the creation netns and container root gets EPERM, as it does
> for ip6tnl and sit; "ip link del" keeps working.
With net = self->net for all commands, a vti6 moved between two host
netns changes too: SIOCADDTUNNEL issued on it creates the new tunnel in
the creation netns, and ADD and DEL check CAP_NET_ADMIN there. Mainline
vti6 still uses dev_net(dev) for these. ip6tnl and sit already behave
this way, so this is fine, but the message should say it.
Also note: this EPERM holds for the ioctls only, changelink is still
open to container root. See the reply to the cover letter.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-12 13:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 16:31 [Devel] [PATCH hci-8.1 0/6] net/ipv6: fix host panics on tunnels " Denis V. Lunev
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 1/6] net/ip6_tunnel: fix a host panic deleting ip6tnl moved into a CT without ipip Denis V. Lunev
2026-11-10 16:35 ` no-reply
2026-11-12 13:01 ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 2/6] net/sit: fix a host panic deleting sit moved into a CT without sit Denis V. Lunev
2026-11-10 16:36 ` no-reply
2026-11-12 13:01 ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 3/6] ms/ip6: vti: Use ip6_tnl.net in vti6_changelink() Denis V. Lunev
2026-11-10 16:38 ` no-reply
2026-11-12 13:01 ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 4/6] ms/ip6: vti: Use ip6_tnl.net in vti6_siocdevprivate() Denis V. Lunev
2026-11-10 16:41 ` no-reply
2026-11-12 13:01 ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 5/6] ms/ip6_vti: set netns_immutable on the fallback device Denis V. Lunev
2026-11-10 16:41 ` no-reply
2026-11-12 13:01 ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 6/6] net/ip6_vti: fix host panics on a vti6 tunnel moved into a CT Denis V. Lunev
2026-11-10 16:42 ` no-reply
2026-11-12 13:01 ` Konstantin Khorenko [this message]
2026-11-12 13:01 ` [Devel] [PATCH hci-8.1 0/6] net/ipv6: fix host panics on tunnels " Konstantin Khorenko
2026-11-12 13:01 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179448849599.4060562.16427190740606014474.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox