OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: [Devel] [PATCH hci-8.1 1/6] net/ip6_tunnel: fix a host panic deleting ip6tnl moved into a CT without ipip
Date: Tue, 10 Nov 2026 17:31:25 +0100	[thread overview]
Message-ID: <20261110163130.2776687-2-den@openvz.org> (raw)
In-Reply-To: <20261110163130.2776687-1-den@openvz.org>

From: Denis V. Lunev <den@openvz.org>

ip6_tnl_init_net() frees the ip6_tnl_net of a netns whose VE lacks
VE_FEATURE_IPIP. Only the fallback ip6tnl0 is netns_immutable, so the
host can move any other ip6tnl tunnel into such a container with
"ip link set t6 netns <CT>". ip6_tnl_dellink() looks ip6n up in
dev_net(dev) and reads ip6n->fb_tnl_dev, so the node panics on a NULL
pointer dereference when container root deletes the tunnel, when the
container stops and cleanup_net() deletes it, or when ip6_tunnel is
unloaded.

Take ip6n from t->net, the netns the tunnel was created in and is
hashed in, as changelink, uninit and the ioctl path already do. The
fallback device cannot leave its netns, so the fb_tnl_dev comparison
keeps its meaning.

Fixes: 94e61c310587 ("net/ip6ip: Consider VE_FEATURE_IPIP on new net creation")

https://virtuozzo.atlassian.net/browse/VSTOR-154346
Feature: ve: per-CT features management
Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 net/ipv6/ip6_tunnel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index 9694480cdaff..a7667de2c451 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -2095,8 +2095,8 @@ static int ip6_tnl_changelink(struct net_device *dev, struct nlattr *tb[],
 
 static void ip6_tnl_dellink(struct net_device *dev, struct list_head *head)
 {
-	struct net *net = dev_net(dev);
-	struct ip6_tnl_net *ip6n = net_generic(net, ip6_tnl_net_id);
+	struct ip6_tnl *t = netdev_priv(dev);
+	struct ip6_tnl_net *ip6n = net_generic(t->net, ip6_tnl_net_id);
 
 	if (dev != ip6n->fb_tnl_dev)
 		unregister_netdevice_queue(dev, head);
-- 
2.53.0

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-10 16:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 16:31 [Devel] [PATCH hci-8.1 0/6] net/ipv6: fix host panics on tunnels moved into a CT Denis V. Lunev
2026-11-10 16:31 ` Denis V. Lunev [this message]
2026-11-10 16:35   ` [Devel] [PATCH hci-8.1 1/6] net/ip6_tunnel: fix a host panic deleting ip6tnl moved into a CT without ipip no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 2/6] net/sit: fix a host panic deleting sit moved into a CT without sit Denis V. Lunev
2026-11-10 16:36   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 3/6] ms/ip6: vti: Use ip6_tnl.net in vti6_changelink() Denis V. Lunev
2026-11-10 16:38   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 4/6] ms/ip6: vti: Use ip6_tnl.net in vti6_siocdevprivate() Denis V. Lunev
2026-11-10 16:41   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 5/6] ms/ip6_vti: set netns_immutable on the fallback device Denis V. Lunev
2026-11-10 16:41   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-10 16:31 ` [Devel] [PATCH hci-8.1 6/6] net/ip6_vti: fix host panics on a vti6 tunnel moved into a CT Denis V. Lunev
2026-11-10 16:42   ` no-reply
2026-11-12 13:01   ` Konstantin Khorenko
2026-11-12 13:01 ` [Devel] [PATCH hci-8.1 0/6] net/ipv6: fix host panics on tunnels " Konstantin Khorenko
2026-11-12 13:01 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110163130.2776687-2-den@openvz.org \
    --to=den@openvz.org \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox