OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v5 0/5] Fix kernel crash in overlayfs
Date: Thu, 12 Nov 2026 14:17:01 +0100	[thread overview]
Message-ID: <179448942112.4060562.12799497421042932533.b4-review@b4> (raw)
In-Reply-To: <20261110-ovl-use-orig-ve-v5-0-f3f2bdb29e23@virtuozzo.com>

I won't apply this version, please send v6 with the changes below.

On Tue, 10 Nov 2026 18:26:47 +0100, Vladimir Riabchun <vladimir.riabchun@virtuozzo.com> wrote:
> Vladimir Riabchun (5):
>       ve: Remove STOPPED state
>       ve: Introduce override_ve/revert_ve helpers
>       ve: Defer ve creds drop until ve is completely destroyed
>       ovl: Keep creator VE in overlayfs superblock
>       ve/overlayfs: Override VE together with creds

The approach works: the criu oops is gone, the "CT stopped while the
overlay is still in use" case is closed by patches 3 and 4, and a CT
using a host overlay (GPU passthrough) behaves as before. What is left
is small.

What to change for v6:

1. Patches 2 and 5, code: a CT task asking override_ve() for VE0 gets
   its current override back (no change) instead of ERR_PTR(-EPERM).
   Cross-CT returns ERR_PTR(-EPERM) instead of -EINVAL.
   ovl_override_creds() and ovl_revert_creds() then test only
   IS_ERR(). Change the comment "Cross-CT mounts are forbidden" to say
   that using an overlayfs from another CT is refused.
2. Patch 2, code: do not print ve_name(new_ve) in the "Invalid VE
   override" message.
3. Patch 2, code: WARN_ON_ONCE instead of WARN_ON in
   dup_task_struct().
4. Patch 3, code: the two "ve isn't running" comments in
   kernel/capability.c now mean "ve was never started", fix them.
5. Patch 1, message: restore Pavel's Reviewed-by from v2 (the diff has
   not changed since), "stated" -> "state".
6. Patch 2, message: rewrite the garbled fork sentence, and say that
   ve_capable() now uses overrided_ve and which VE switches are
   allowed, refused, or silently skipped.
7. Patch 4, message: drop the blank line before Signed-off-by.
8. Patch 5, message: add a Fixes tag for ec01a90d0ef9 ("ovl: replace
   capable by ve_capable for indexing feature"), fix "swich" and
   "Stroing", say why cross-CT use must fail, and limit the "compile
   error for new users" claim to ovl_override_creds().
9. All patches: add a Feature line. Patches 1-3: "ve: ve generic
   structures" (as ed9325c6f4ce6), patches 4-5: "ve: CRIU support"
   (as ec01a90d0ef9).
10. Cover letter: the "v2:" link points to the 20 Sep two-patch series,
    and "reworked completely after v2" is wrong (override_ve() came
    with the 22 Oct v1). Mention that cross-CT use now fails, and name
    the Jira task for the backing_file gap (item 1 below).
11. All patches: add the Reviewed-by of Vasileios Almpanis, which he
    gave on the v5 cover letter; the v6 changes above are small enough
    to keep it.

Separate patches, not needed for v6:

1. backing_file_ctx.cred = ovl_creds() (read_iter, write_iter, splice,
   mmap) still switches creds without the VE. Nothing there reaches
   ve_capable() today, so no crash, but it is the same class of bug.
   You said on v2 it would be a separate task; please file it.
2. Optional hardening: a WARN_ON_ONCE(!fh) returning -EIO in
   ovl_create_index() would turn any future creds/VE mismatch into an
   error instead of an oops.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

      parent reply	other threads:[~2026-11-12 13:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 17:26 Vladimir Riabchun
2026-11-10 17:26 ` [Devel] [PATCH hci-8.1 v5 1/5] ve: Remove STOPPED state Vladimir Riabchun
2026-11-10 17:32   ` no-reply
2026-11-12 13:17   ` Konstantin Khorenko
2026-11-10 17:26 ` [Devel] [PATCH hci-8.1 v5 2/5] ve: Introduce override_ve/revert_ve helpers Vladimir Riabchun
2026-11-10 17:35   ` no-reply
2026-11-12 13:17   ` Konstantin Khorenko
2026-11-12 20:41     ` Vladimir Riabchun
2026-11-13 20:21       ` Konstantin Khorenko
2026-11-10 17:26 ` [Devel] [PATCH hci-8.1 v5 3/5] ve: Defer ve creds drop until ve is completely destroyed Vladimir Riabchun
2026-11-10 17:32   ` no-reply
2026-11-12 13:17   ` Konstantin Khorenko
2026-11-16 11:43     ` Vladimir Riabchun
2026-11-10 17:26 ` [Devel] [PATCH hci-8.1 v5 4/5] ovl: Keep creator VE in overlayfs superblock Vladimir Riabchun
2026-11-10 17:32   ` no-reply
2026-11-12 13:17   ` Konstantin Khorenko
2026-11-10 17:26 ` [Devel] [PATCH hci-8.1 v5 5/5] ve/overlayfs: Override VE together with creds Vladimir Riabchun
2026-11-10 17:37   ` no-reply
2026-11-10 17:54     ` Vladimir Riabchun
2026-11-12 13:17   ` Konstantin Khorenko
2026-11-16 11:48     ` Vladimir Riabchun
2026-11-11 12:51 ` [Devel] [PATCH hci-8.1 v5 0/5] Fix kernel crash in overlayfs Vasileios Almpanis
2026-11-12 13:17 ` Konstantin Khorenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179448942112.4060562.12799497421042932533.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=vladimir.riabchun@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox