OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 v2 1/3] fs: let the protection flags of a mount be locked from userspace
Date: Mon, 16 Nov 2026 18:13:33 +0100	[thread overview]
Message-ID: <179484921365.861498.8601646536402367093.b4-review@b4> (raw)
In-Reply-To: <20261116061256.54472-2-mirian.shilakadze@virtuozzo.com>

I won't apply this version, please send v3 with the changes below.

On Mon, 16 Nov 2026 10:12:52 +0400, Mirian Shilakadze <mirian.shilakadze@virtuozzo.com> wrote:
> +	kattr->lock_flags = (attr->attr_set | attr->attr_clr) &
> +			    MOUNT_SETATTR_LOCK_FLAGS;
> +	if (kattr->lock_flags && !capable(CAP_SYS_ADMIN))
> +		return -EPERM;
> +	if (attr->attr_clr & MOUNT_ATTR_VE_LOCK)
> +		return -EINVAL;
> +	if (kattr->lock_flags && kattr->recurse)
> +		return -EINVAL;

Item 5 of the cover letter reply: give the reasons for the two choices
here in the message.

- The ve0 test: in the v1 review I asked to keep it. Dropping it is
  fine now that a lock cannot be dropped: host root that joined a
  container's ve can only add restrictions. One sentence says so.
- AT_RECURSIVE: only the s_umount of this mount's superblock is held,
  submounts on other superblocks would reopen the remount race.

Sashiko's point that a lock bit on an unset protection returns 0 and
locks nothing needs no change: the message and the UAPI comment say a
lock stands only where its protection is set, and MOUNT_ATTR_VE_LOCK
relies on that to lock whatever is set.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-16 17:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  6:12 [Devel] [PATCH vz10 v2 0/3] fs: let the host lock the protection flags of a mount Mirian Shilakadze
2026-11-16  6:12 ` [Devel] [PATCH vz10 v2 1/3] fs: let the protection flags of a mount be locked from userspace Mirian Shilakadze
2026-11-16  6:24   ` no-reply
2026-11-16 17:13   ` Konstantin Khorenko [this message]
2026-11-16  6:12 ` [Devel] [PATCH vz10 v2 2/3] fs: report the locks of a mount in statmount() Mirian Shilakadze
2026-11-16  6:17   ` no-reply
2026-11-16 17:13   ` Konstantin Khorenko
2026-11-16  6:12 ` [Devel] [PATCH vz10 v2 3/3] selftests/ve: test locking a mount from the host Mirian Shilakadze
2026-11-16  6:38   ` no-reply
2026-11-16 17:13   ` Konstantin Khorenko
2026-11-16 17:13 ` [Devel] [PATCH vz10 v2 0/3] fs: let the host lock the protection flags of a mount Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179484921365.861498.8601646536402367093.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=mirian.shilakadze@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox