From: Konstantin Khorenko <khorenko@virtuozzo.com>
Subject: [Devel] [PATCH vz10 v2] selftests/tdx: skip when the TDX guest device is absent
Date: Mon, 24 Aug 2026 14:39:37 +0200 [thread overview]
Message-ID: <20260824123937.442700-1-khorenko@virtuozzo.com> (raw)
In-Reply-To: <20260821150706.793224-1-eva.kurchatova@virtuozzo.com>
From: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
verify_report fails outside a TDX guest, where /dev/tdx_guest does not
exist.
Skip only when the device node is missing, so that a real open()
failure, EPERM or EBUSY, still fails the test instead of being
reported as a skip.
https://virtuozzo.atlassian.net/browse/VSTOR-142444
Feature: fix selftests
Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
Changes in v2:
- skip only when the device node itself is missing (errno == ENOENT).
v1 skipped on any open() failure, so a real problem such as EPERM or
EBUSY was reported as a skip instead of a failure. As a side effect
the following ASSERT_LT() is reachable again and no longer dead code.
- commit message: explain why the skip is narrowed to a missing node.
tools/testing/selftests/tdx/tdx_guest_test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/tdx/tdx_guest_test.c b/tools/testing/selftests/tdx/tdx_guest_test.c
index 81d8cb88ea1a..612005b10f7c 100644
--- a/tools/testing/selftests/tdx/tdx_guest_test.c
+++ b/tools/testing/selftests/tdx/tdx_guest_test.c
@@ -135,6 +135,8 @@ TEST(verify_report)
int devfd, i;
devfd = open(TDX_GUEST_DEVNAME, O_RDWR | O_SYNC);
+ if (devfd < 0 && errno == ENOENT)
+ SKIP(return, "TDX guest device is not available");
ASSERT_LT(0, devfd);
/* Generate sample report data */
--
2.47.1
next prev parent reply other threads:[~2026-08-24 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 15:07 [Devel] [PATCH vz10] " Eva Kurchatova
2026-08-24 12:39 ` Konstantin Khorenko [this message]
2026-08-24 12:39 ` [Devel] [PATCH RHEL10 COMMIT] " Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824123937.442700-1-khorenko@virtuozzo.com \
--to=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox