[Devel] [PATCH hci-8.1 v2] selftests: forwarding: flush neighbours in the locked port MAB test

[Devel] [PATCH hci-8.1 v2] selftests: forwarding: flush neighbours in the locked port MAB test

[Eva Kurchatova]

locked_port_mab starts with the neighbour entry for 192.0.2.2 that
locked_port_ipv4 left behind, and the locked bridge port then drops
h1's traffic for two pings, long enough for that entry to time out.
The locked ping starts a broadcast resolution, which the port drops as
well. When it fails after the FDB entry is replaced, the next ping has
already queued its first packet and gets "Destination Host
Unreachable", and since ping runs with a deadline, it stops at that
error. The check "Ping did not work after replacing FDB entry" then
fails.

Flush h1's neighbours after replacing the FDB entry, so that the ping
starts a fresh resolution.

Fixes: 4a331d346996 ("selftests: forwarding: Add MAC Authentication Bypass (MAB) test cases")
https://virtuozzo.atlassian.net/browse/VSTOR-153057
Feature: fix selftests

Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
---

Changes in v2:
- Flush only in locked_port_mab, the one case where the entry is old
  enough to time out while the port is locked; the ipv6 flush hid the
  failure by removing that entry early. Keep only the Fixes tag of the
  MAB test.
- Describe the resolution.

 tools/testing/selftests/net/forwarding/bridge_locked_port.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
index c62331b2e006..e0bf223d5f46 100755
--- a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
+++ b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
@@ -201,6 +201,7 @@ locked_port_mab()
 	check_err $? "Locked FDB entry not created"
 
 	bridge fdb replace `mac_get $h1` dev $swp1 master static
+	ip neigh flush dev $h1
 
 	ping_do $h1 192.0.2.2
 	check_err $? "Ping did not work after replacing FDB entry"
-- 
2.56.0

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

Re: [Devel] [PATCH hci-8.1 v2] selftests: forwarding: flush neighbours in the locked port MAB test

[no-reply]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests: commit message has non-upstream Jira URL and Feature: trailer
--

commit 14e4827eb4828e3a2b673ab078fcd08a723d8929
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

selftests: forwarding: flush neighbours in the locked port MAB test

This commit adds an "ip neigh flush dev $h1" after the FDB entry is
replaced in locked_port_mab(). With the flush, the following ping starts
a fresh neighbour resolution instead of reusing an entry that timed out
while the port was locked.

> selftests: forwarding: flush neighbours in the locked port MAB test
>
> locked_port_mab starts with the neighbour entry for 192.0.2.2 that
> [ ... ]
> Fixes: 4a331d346996 ("selftests: forwarding: Add MAC Authentication Bypass (MAB) test cases")
> https://virtuozzo.atlassian.net/browse/VSTOR-153057
> Feature: fix selftests
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

[Severity: Low]
This isn't a bug in the code, but the commit message has two lines that
don't belong in an upstream changelog:

https://virtuozzo.atlassian.net/browse/VSTOR-153057
Feature: fix selftests

The first line points to a private issue tracker that other readers can't
open. The second is a "Feature:" trailer, which isn't a recognized kernel
trailer.

Could both lines be dropped if this patch is sent to mainline or netdev?

> diff --git a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
> --- a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
> +++ b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh

[ ... ]

> @@ -201,6 +201,7 @@ locked_port_mab()
>  	check_err $? "Locked FDB entry not created"
>  
>  	bridge fdb replace `mac_get $h1` dev $swp1 master static
> +	ip neigh flush dev $h1
>  
>  	ping_do $h1 192.0.2.2
>  	check_err $? "Ping did not work after replacing FDB entry"

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261103173335.2585426-1-eva.kurchatova@virtuozzo.com?part=1

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

Re: [Devel] [PATCH hci-8.1 v2] selftests: forwarding: flush neighbours in the locked port MAB test

[Eva Kurchatova (Virtuozzo)]

On 11/3/26 19:36, no-reply@sashiko.virtuozzo.com wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] selftests: commit message has non-upstream Jira URL and Feature: trailer
> --
>
> commit 14e4827eb4828e3a2b673ab078fcd08a723d8929
> Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
>
> selftests: forwarding: flush neighbours in the locked port MAB test
>
> This commit adds an "ip neigh flush dev $h1" after the FDB entry is
> replaced in locked_port_mab(). With the flush, the following ping starts
> a fresh neighbour resolution instead of reusing an entry that timed out
> while the port was locked.
>
>> selftests: forwarding: flush neighbours in the locked port MAB test
>>
>> locked_port_mab starts with the neighbour entry for 192.0.2.2 that
>> [ ... ]
>> Fixes: 4a331d346996 ("selftests: forwarding: Add MAC Authentication Bypass (MAB) test cases")
>> https://virtuozzo.atlassian.net/browse/VSTOR-153057
>> Feature: fix selftests
>>
>> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
> [Severity: Low]
> This isn't a bug in the code, but the commit message has two lines that
> don't belong in an upstream changelog:
>
> https://virtuozzo.atlassian.net/browse/VSTOR-153057
> Feature: fix selftests
>
> The first line points to a private issue tracker that other readers can't
> open. The second is a "Feature:" trailer, which isn't a recognized kernel
> trailer.
>
> Could both lines be dropped if this patch is sent to mainline or netdev?
>
>> diff --git a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
>> --- a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
>> +++ b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
> [ ... ]
>
>> @@ -201,6 +201,7 @@ locked_port_mab()
>>   	check_err $? "Locked FDB entry not created"
>>   
>>   	bridge fdb replace `mac_get $h1` dev $swp1 master static
>> +	ip neigh flush dev $h1
>>   
>>   	ping_do $h1 192.0.2.2
>>   	check_err $? "Ping did not work after replacing FDB entry"
Indeed so, this is not an upstream mailing list either. The trailers are 
intentional requirement.
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

Re: [Devel] [PATCH hci-8.1 v2] selftests: forwarding: flush neighbours in the locked port MAB test

[Konstantin Khorenko]

Applying with this fixed on my side:

- split the first paragraph of the commit message: one fact per
  sentence, the failure in its own paragraph.

On Tue, 03 Nov 2026 19:31:54 +0200, Eva Kurchatova wrote:
> Fixes: 4a331d346996 ("selftests: forwarding: Add MAC Authentication Bypass (MAB) test cases")
> https://virtuozzo.atlassian.net/browse/VSTOR-153057

The mainline task VSTOR-153083 still describes v1: all four hunks, both
Fixes tags and the old explanation. Please update it to this version
before sending upstream.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

Re: [Devel] [PATCH hci-8.1 v2] selftests: forwarding: flush neighbours in the locked port MAB test

[Konstantin Khorenko]

On Tue, 03 Nov 2026 19:31:54 +0200, Eva Kurchatova wrote:
> selftests: forwarding: flush neighbours in the locked port MAB test

Applied to branch-rh10-6.12.0-211.52.1.22.x.vz10-ovz, will be released in rh10-6.12.0-211.52.1.22.18.vz10, thanks!

[1/1] selftests: forwarding: flush neighbours in the locked port MAB test
      https://bitbucket.org/virtuozzocore/vzkernel.vzs/commits/c0099be6851a

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel