From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>, andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 0/4] dm-ploop: fix acknowledged writes lost when discard and allocation share a BAT writeback
Date: Mon, 2 Nov 2026 16:32:39 +0100 [thread overview]
Message-ID: <93682330-fabd-44c0-bc75-e1c83799a9c8@virtuozzo.com> (raw)
In-Reply-To: <20261028143647.2972030-1-den@openvz.org>
Hi Den,
the patches look good to me, no changes needed.
While reviewing them I found a few problems nearby, all older than the
series:
- A failed cluster copy on grow leaves MD_UPDATING and MD_DIRTY set on
the BAT page. After the resume every allocating write, discard or COW
on that page waits in wait_llist forever.
https://virtuozzo.atlassian.net/browse/VSTOR-152981
- ploop_suspend_submitting_pios() does not wait for the allocator
thread, which can read a deltas[] slot being vacated by a merge and
oops on a NULL file or truncate the top image. 2/4 adds the same
memset as notify_delta_merged() to merge_latest, so the window now
exists there too.
https://virtuozzo.atlassian.net/browse/VSTOR-152984
- ploop_submit_embedded_pio() checks stop_submitting_pios without
deferred_lock, so a pio can slip past the suspend of submission or
get stuck in llsuspended_pios after the resume.
https://virtuozzo.atlassian.net/browse/VSTOR-152985
--
Best regards,
Konstantin
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-11-02 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 14:36 Denis V. Lunev
2026-10-28 14:36 ` [Devel] [PATCH hci-8.1 v2 1/4] dm-ploop: fix freeing the wrong clusters when a BAT writeback fails Denis V. Lunev
2026-10-28 15:00 ` no-reply
2026-10-28 14:36 ` [Devel] [PATCH hci-8.1 v2 2/4] dm-ploop: renumber BAT levels when the latest snapshot is merged Denis V. Lunev
2026-10-28 15:00 ` no-reply
2026-10-28 14:36 ` [Devel] [PATCH hci-8.1 v2 3/4] dm-ploop: drop the dead PLOOP_DELAYWB code Denis V. Lunev
2026-10-28 15:00 ` no-reply
2026-10-28 14:36 ` [Devel] [PATCH hci-8.1 v2 4/4] dm-ploop: fix lost BAT updates when alloc and discard share a writeback Denis V. Lunev
2026-10-28 15:06 ` no-reply
2026-10-28 15:16 ` [Devel] [PATCH hci-8.1 v2 0/4] dm-ploop: fix acknowledged writes lost when discard and allocation share a BAT writeback Andrey Zhadchenko
2026-11-02 10:42 ` Konstantin Khorenko
2026-11-02 10:44 ` Konstantin Khorenko
2026-11-02 15:32 ` Konstantin Khorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93682330-fabd-44c0-bc75-e1c83799a9c8@virtuozzo.com \
--to=khorenko@virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox