From: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com,
Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v6 1/5] ve: Remove STOPPED state
Date: Mon, 16 Nov 2026 17:25:28 +0100 [thread overview]
Message-ID: <9af3c346-1be1-489c-a05f-355f95315755@virtuozzo.com> (raw)
In-Reply-To: <010701a1e520359d-b1576852-d1d1-424a-be45-aab52bd9a6eb-000000@eu-central-1.amazonses.com>
On 11/16/26 17:10, no-reply@sashiko.virtuozzo.com wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] ve: commit message omits removal of DEAD transition in
> ve_destroy()
> --
>
> commit 6a34f90f8fbb9ff68c8aa5b754aa9b1d014675fb
> Author: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
>
> ve: Remove STOPPED state
>
> This commit drops the separate VE_STATE_STOPPED state and moves the VE directly to VE_STATE_DEAD when it is stopped, both on the ve_start_container() error path and in ve_exit_ns().
>
>> diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c
>> index 6cdfaaa4e703..b3988a8d590f 100644
>> --- a/kernel/ve/ve.c
>> +++ b/kernel/ve/ve.c
>
> [ ... ]
>
>> @@ -939,7 +939,6 @@ static void ve_destroy(struct cgroup_subsys_state *css)
>> ve_free_vdso(ve);
>> mntput(ve->devtmpfs_mnt);
>> free_percpu(ve->sched_lat_ve.cur);
>> - ve_set_state(ve, VE_STATE_DEAD);
>> kmem_cache_free(ve_cachep, ve);
>> }
>
> [Severity: Low]
> The commit message does not mention that this DEAD transition in ve_destroy() is removed. Could it say so, and why it is safe?
No comments about it because this is clear from the code and
commit description.
>
> The removal looks necessary. DEAD is now set in ve_exit_ns() and in the ve_start_container() error path, so keeping this call would hit the "already DEAD" warning in ve_set_state(). The old call was also a store to an object freed on the next line. As a result, a VE destroyed while still in STARTING never reaches DEAD, which the message could also state.
>
--
Best regards, Riabchun Vladimir
Linux Kernel Developer, Virtuozzo
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 16:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:06 [Devel] [PATCH hci-8.1 v6 0/5] Fix kernel crash in overlayfs Vladimir Riabchun
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 1/5] ve: Remove STOPPED state Vladimir Riabchun
2026-11-16 16:10 ` no-reply
2026-11-16 16:25 ` Vladimir Riabchun [this message]
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 2/5] ve: Introduce override_ve/revert_ve helpers Vladimir Riabchun
2026-11-16 16:12 ` no-reply
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 3/5] ve: Defer ve creds drop until ve is completely destroyed Vladimir Riabchun
2026-11-16 16:14 ` no-reply
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 4/5] ovl: Keep creator VE in overlayfs superblock Vladimir Riabchun
2026-11-16 16:13 ` no-reply
2026-11-16 16:06 ` [Devel] [PATCH hci-8.1 v6 5/5] ve/overlayfs: Override VE together with creds Vladimir Riabchun
2026-11-16 16:19 ` no-reply
2026-11-16 16:52 ` Vladimir Riabchun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9af3c346-1be1-489c-a05f-355f95315755@virtuozzo.com \
--to=vladimir.riabchun@virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=vasileios.almpanis@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox