Re: [PATCH hci-8.1 v4 3/5] vhost-blk: use a local vhost_dev pointer in start and stop

[no-reply@sashiko.virtuozzo.com]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] vhost-blk: Fixes tag on a no-functional-change refactor
--

commit e32c7620df63e11379f613aefad8997664c58582
Author: Alexander Ivanov <alexander.ivanov@virtuozzo.com>

vhost-blk: use a local vhost_dev pointer in start and stop

This patch adds a local struct vhost_dev pointer, hdev, in vhost_blk_start()
and vhost_blk_stop(). It replaces each use of &s->dev with hdev. The commit
message says there is no functional change.

Link: https://virtuozzo.atlassian.net/browse/VSTOR-107537

This isn't a bug in the code, but the commit message has a problem.

> vhost-blk: use a local vhost_dev pointer in start and stop
>
> Take &s->dev once into hdev in vhost_blk_start() and vhost_blk_stop()
> instead of spelling it out at every use. No functional change.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-107537
>
> Fixes: 0ff3cb5ff28f ("block: add vhost-blk backend")
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>

[Severity: Low]
The message says "No functional change", yet it carries a Fixes: tag
pointing at 0ff3cb5ff28f ("block: add vhost-blk backend").

The only edits are the new local alias in vhost_blk_start() and
vhost_blk_stop():

    struct vhost_dev *hdev = &s->dev;

and the replacement of &s->dev with hdev at each use. Nothing in the diff
fixes a bug.

Could the Fixes: tag be dropped? Stable-backport tooling may otherwise pick
up this cosmetic cleanup.

If a real bug is being fixed, could the commit message describe it?

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261029092301.3286535-1-alexander.ivanov@virtuozzo.com?part=3