Re: [PATCH QEMU HCI-8.1 v7 00/35] vfio: support qemu-update with passed through GPU's and vGPU's #VSTOR-103860

["Denis V. Lunev" <den@virtuozzo.com>]

On 11/3/26 14:57, Andrey Drobyshev wrote:
> v6 -> v7:
>
> Fixes of the issues found by Sashiko AI review.
>
> - Patch 4 ("migration/cpr-exec: require a file or exec migration URI"):
>   the message says the check covers the incoming URI too
>
> - Patch 6 ("migration/cpr-exec: close the persisted state if the
>   channel fails to open"): the fd is parsed before its variable is
>   unset
>
> - Patch 7 (NEW) ("migration/cpr-exec: don't leak the dup'd memfd if
>   g_setenv() fails"): the dup was leaked on that path and a failed
>   dup() went unchecked; the patches after it are renumbered
>
> - Patch 32 -> 33 ("VZ: vfio/region: preserve BAR mappings across
>   cpr-exec"): CPR.rst no longer says cpr-transfer preserves VFIO
>   devices
>
> - Patch 34 -> 35 ("VZ: vfio/migration: don't wait for stop-copy-only
>   device state"): the message covers devices without pre-copy, which
>   the rule applies to as well
>
> v6: http://lore.virtuozzo.com/20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com
> ---
> Akihiko Odaki (1):
>       vfio/pci: Grow buffer in vfio_pci_host_match()
>
> Andrey Drobyshev (21):
>       VZ: migration/cpr-exec: fix Error leak in preserve_ram()
>       migration/cpr-exec: restore RAM write access if exec fails
>       vfio/region: create BAR dma-bufs with O_CLOEXEC
>       migration/cpr-exec: require a file or exec migration URI
>       migration: close the CPR state if the outgoing channel fails to open
>       migration/cpr-exec: close the persisted state if the channel fails to open
>       migration/cpr-exec: don't leak the dup'd memfd if g_setenv() fails
>       migration: don't refuse a blocker over a migration of another mode
>       kvm: tolerate ioctls after kvm_close()
>       kvm: fix coalesced MMIO flush racing with kvm_close()
>       migration/cpr: add cpr_is_in_progress()
>       vfio/migration: don't migrate device state during CPR
>       vfio/migration: don't assume the device is running on CPR incoming
>       migration/ram: don't start dirty logging in CPR modes
>       VZ: vfio/cpr: don't close KVM on cpr-exec
>       VZ: migration/cpr-exec: abort cpr-exec if memory can't be preserved
>       VZ: migration/cpr-exec: take the vhost-net devices back if exec fails
>       VZ: migration/cpr-exec: don't exec if a vhost-net device can't be released
>       VZ: vfio/region: preserve BAR mappings across cpr-exec #VSTOR-103860
>       VZ: migration/cpr-exec: allow cpr-exec with VFIO devices #VSTOR-103860
>       VZ: vfio/migration: don't wait for stop-copy-only device state #VSTOR-141821
>
> Arun Menon (1):
>       migration: Fix regression of passing error_fatal into vmstate_load_state()
>
> Cédric Le Goater (2):
>       vfio/pci: Reject invalid MSI-X Table and PBA BIR values
>       vfio/pci: Fix information leak in vfio_rom_read()
>
> Fabiano Rosas (3):
>       migration: yank: Move register instance earlier
>       migration: Free cpr-transfer MigrationAddress along with gsource
>       migration: Move CPR HUP watch to cpr-transfer.c
>
> Igor Mammedov (1):
>       q35: Fix migration of SMRAM state
>
> Mario Casquero (1):
>       vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom()
>
> Markus Armbruster (1):
>       migration: Plug memory leaks after migrate_set_error()
>
> Peter Xu (1):
>       migration: Fix crash on second migration when cancel early
>
> Tycho Andersen (AMD) (1):
>       hw/vfio: Fix liveness check in vfio_connect_kvm_msi_virq()
>
> Vladimir Sementsov-Ogievskiy (1):
>       migration: vmstate_save_state_v: fix double error_setg
>
> Yanfei Xu (1):
>       migration: ensure APIC is loaded prior to VFIO PCI devices
>
>  accel/kvm/kvm-all.c           |  24 +++++++-
>  docs/devel/migration/CPR.rst  |  12 ++--
>  hw/display/virtio-gpu.c       |  22 +++++---
>  hw/intc/apic_common.c         |   1 +
>  hw/net/vhost_net.c            |  62 ++++++++++++++++++++-
>  hw/pci-host/q35.c             |  25 ++++-----
>  hw/pci/pci.c                  |  15 ++++-
>  hw/s390x/virtio-ccw.c         |  17 +++++-
>  hw/scsi/spapr_vscsi.c         |  10 +++-
>  hw/vfio/cpr.c                 |  11 ++--
>  hw/vfio/device.c              |  29 +++++++---
>  hw/vfio/migration-multifd.c   |   2 +
>  hw/vfio/migration.c           |  68 ++++++++++++++++++++---
>  hw/vfio/pci.c                 |  25 ++++++---
>  hw/vfio/region.c              |  51 ++++++++++++++++-
>  hw/virtio/virtio-mmio.c       |  15 ++++-
>  hw/virtio/virtio-pci.c        |  15 ++++-
>  hw/virtio/virtio.c            |  10 +++-
>  include/hw/vfio/vfio-cpr.h    |   1 +
>  include/hw/vfio/vfio-device.h |   2 -
>  include/hw/virtio/vhost.h     |   2 +
>  include/migration/cpr.h       |   7 +++
>  include/migration/vmstate.h   |   1 +
>  include/net/vhost_net.h       |   3 +-
>  migration/cpr-exec.c          |  54 +++++++++++++++---
>  migration/cpr-transfer.c      |  33 +++++++++++
>  migration/cpr.c               |  22 ++++++++
>  migration/migration.c         | 126 ++++++++++++++++++++++++------------------
>  migration/migration.h         |   5 ++
>  migration/multifd.c           |   2 +
>  migration/ram.c               |   7 ++-
>  migration/vmstate.c           |   7 ++-
>  tests/qtest/q35-test.c        |   6 --
>  33 files changed, 546 insertions(+), 146 deletions(-)
> ---
> base-commit: 1c84596876fb77b3e25d56cd4a4fa0c32f1faa32
> change-id: 20261009-vfio_v1-a176cddd6b64
>
> Best regards,
> --  
> Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Ack