* Re: [QEMU HCI-8.0 PATCH v3 0/4] vhost-blk: improve feature negotiation
[not found] <20260825172736.269590-1-andrey.zhadchenko@virtuozzo.com>
@ 2026-08-27 13:00 ` Andrey Drobyshev
0 siblings, 0 replies; only message in thread
From: Andrey Drobyshev @ 2026-08-27 13:00 UTC (permalink / raw)
To: Andrey Zhadchenko, den; +Cc: svt-core
On 8/25/26 8:27 PM, Andrey Zhadchenko wrote:
> Feature negotiation in vhost-blk is a bit of a mess:
> - offering VIRTIO_BLK_F_SIZE_MAX along with size_max == 0 is a
> bug which causes win2012 crashes
> - kernel not allowed to reject some actually unimplmented
> feature bits
> - flush is not offered to the guests despite kernel support
> - duplicate ioctls
>
> Fix everything above.
>
> v3:
> - separated patches per reviewer requests
> - add new patch dropping extra VHOST_GET_FEATURES ioctl
>
> Andrey Zhadchenko (4):
> vhost-blk: never offer VIRTIO_BLK_F_SIZE_MAX
> vhost-blk: expand list of the features kernel can refuse
> vhost-blk: offer VIRTIO_BLK_F_FLUSH
> vhost-blk: drop vhost_dev.backend_features use
>
> hw/block/vhost-blk.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
Fixed my own comment to patch 3 myself. With that:
Reviewed-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Applied to hci-8.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-27 13:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20260825172736.269590-1-andrey.zhadchenko@virtuozzo.com>
2026-08-27 13:00 ` [QEMU HCI-8.0 PATCH v3 0/4] vhost-blk: improve feature negotiation Andrey Drobyshev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox