All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: khorenko@virtuozzo.com, Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 1/6] ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS
Date: Mon, 19 Oct 2026 00:12:06 +0000	[thread overview]
Message-ID: <010701a1518051bf-b2c0e763-4260-45d1-afe3-260e4c6f8f0f-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261019000649.1371025-2-eva.kurchatova@virtuozzo.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: stale CONFIG_GENERIC_VDSO_TIME_NS=y left in shipped x86_64 configs
--

commit 58fc0fc4b4942154ef41adeca15ad8a7447eb83c
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS

This commit is a cherry-pick of upstream bad53ae2dc42. It removes the
GENERIC_VDSO_TIME_NS Kconfig symbol and every select of it. TIME_NS now
depends on GENERIC_GETTIMEOFDAY instead.

Link: https://lore.kernel.org/all/20250826-vdso-cleanups-v1-10-d9b65750e49f@linutronix.de

> diff --git a/lib/vdso/Kconfig b/lib/vdso/Kconfig
> index 45df764b49ad6..a1cc90133cb9e 100644
> --- a/lib/vdso/Kconfig
> +++ b/lib/vdso/Kconfig
> @@ -24,12 +24,6 @@ config GENERIC_COMPAT_VDSO
>  	help
>  	  This config option enables the compat VDSO layer.
>  
> -config GENERIC_VDSO_TIME_NS
> -	bool
> -	help
> -	  Selected by architectures which support time namespaces in the
> -	  VDSO
> -
>  config GENERIC_VDSO_OVERFLOW_PROTECT
>  	bool
>  	help

[Severity: Low]
This patch removes config GENERIC_VDSO_TIME_NS, but the shipped x86_64
configs still set it. Should those two entries be dropped too?

configs/kernel-6.12.0-x86_64.config:
CONFIG_GENERIC_VDSO_TIME_NS=y

configs/kernel-6.12.0-x86_64-debug.config:
CONFIG_GENERIC_VDSO_TIME_NS=y

A git grep at the end of the series still finds the symbol in both files.
The series does remove it from config.vz10.minimal, so only these two files
remain.

Kconfig ignores unknown symbols during oldconfig and olddefconfig, so I
don't expect a build or runtime effect. A config-sync or diff check may
report the two lines as stale.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261019000649.1371025-1-eva.kurchatova@virtuozzo.com?part=1

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-10-19  0:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  0:05 [Devel] [PATCH hci-8.1 v2 0/6] timens: Remove dependency on the vDSO Eva Kurchatova
2026-10-19  0:05 ` [Devel] [PATCH hci-8.1 v2 1/6] ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS Eva Kurchatova
2026-10-19  0:12   ` no-reply [this message]
2026-10-19  0:05 ` [Devel] [PATCH hci-8.1 v2 2/6] ms/vdso/timens: Move functions to new file Eva Kurchatova
2026-10-19  0:12   ` no-reply
2026-10-19  0:05 ` [Devel] [PATCH hci-8.1 v2 3/6] ms/timens: Remove dependency on the vDSO Eva Kurchatova
2026-10-19  0:15   ` no-reply
2026-10-19  0:05 ` [Devel] [PATCH hci-8.1 v2 4/6] timens: freeze the offsets on the first join without the vDSO too Eva Kurchatova
2026-10-19  0:14   ` no-reply
2026-10-19  0:05 ` [Devel] [PATCH hci-8.1 v2 5/6] timens: keep the option off where the vDSO updates its own time data Eva Kurchatova
2026-10-19  0:16   ` no-reply
2026-10-19  0:05 ` [Devel] [PATCH hci-8.1 v2 6/6] config: follow the TIME_NS Kconfig change in config.vz10.minimal Eva Kurchatova
2026-10-19  0:16   ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1518051bf-b2c0e763-4260-45d1-afe3-260e4c6f8f0f-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.