Re: [Devel] [PATCH hci-8.1 v2 2/6] ms/vdso/timens: Move functions to new file

[no-reply@sashiko.virtuozzo.com]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] timens: stale extern offset_lock left in time_namespace.h after rename
--

commit 10270c644c766f4ad4754e8bd546e29088de7a79
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

ms/vdso/timens: Move functions to new file

This commit moves the glue functions between time namespaces and the vDSO
into a new file, kernel/time/namespace_vdso.c. It renames offset_lock to
timens_offset_lock, declared in a new private header, and converts the
mutex and mmap_read_lock() users to guard().

Link: https://patch.msgid.link/20260326-vdso-timens-decoupling-v2-1-c82693a7775f@linutronix.de

> diff --git a/include/linux/time_namespace.h b/include/linux/time_namespace.h
> index 3d3b529c5a98b..23384eafebfb5 100644
> --- a/include/linux/time_namespace.h
> +++ b/include/linux/time_namespace.h
> @@ -35,8 +35,6 @@ extern struct time_namespace init_time_ns;
>  extern struct mutex offset_lock;
[Severity: Low]
This isn't a bug, but is this declaration now stale?

The mutex is renamed to timens_offset_lock, defined in
kernel/time/namespace.c:

    DEFINE_MUTEX(timens_offset_lock);

and declared in the new private header namespace_internal.h:

    extern struct mutex timens_offset_lock;

Nothing defines or references offset_lock any more, but this public
declaration is left in include/linux/time_namespace.h, while the
vdso_join_timens() declarations just below it were removed.

Should "extern struct mutex offset_lock;" be dropped from the header as well?

>  
>  #ifdef CONFIG_TIME_NS
> -extern int vdso_join_timens(struct task_struct *task,
> -			    struct time_namespace *ns);
>  extern void timens_commit(struct task_struct *tsk, struct time_namespace *ns);

[ ... ]

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261019000649.1371025-1-eva.kurchatova@virtuozzo.com?part=2

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel