All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: "Denis V. Lunev" <den@openvz.org>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v3 2/5] ms/xfs: don't skip free extents of the longest length in a whole-AG FITRIM
Date: Wed, 11 Nov 2026 11:35:15 +0000	[thread overview]
Message-ID: <010701a1ca6406bf-e60f3af0-b8a4-4709-bb16-0994d7c1ef56-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261111113135.4023555-3-den@openvz.org>

> From: Daejun Park <daejun7.park@samsung.com>
> 
> Since commit a66d636385d6 ("xfs: fix fstrim offset calculations"), the
> by-length walk of an AG in FITRIM starts with
> xfs_alloc_lookup_ge(cur, 0, pagf_longest) and walks down. The lookup
> lands on the longest free extent with the lowest block number. The
> other free extents of that length sort after it and are never
> discarded.
> 
> Start every by-length batch with xfs_alloc_lookup_le() at restart_bno.
> 
> Suggested-by: Dave Chinner <dgc@kernel.org>
> Link: https://lore.kernel.org/r/ZgiJWxVcVwag0fIP@dread.disaster.area
> Cc: stable@vger.kernel.org
> Fixes: a66d636385d6 ("xfs: fix fstrim offset calculations")
> Signed-off-by: Daejun Park <daejun7.park@samsung.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Carlos Maiolino <cem@kernel.org>
> (cherry picked from commit 5745f4f10a1a16aa5bb020acc38afa33f2d5ff99)
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-153590
> 
> Feature: fix ms/xfs
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261111113135.4023555-1-den@openvz.org?part=2


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-11 11:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 11:31 [Devel] [PATCH hci-8.1 v3 0/5] ext4, xfs: discard the balloon on FITRIM Denis V. Lunev
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 1/5] ms/xfs: don't skip free extents in later batches of a whole-AG FITRIM Denis V. Lunev
2026-11-11 11:35   ` no-reply
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 2/5] ms/xfs: don't skip free extents of the longest length in " Denis V. Lunev
2026-11-11 11:35   ` no-reply [this message]
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 3/5] xfs: release the balloon inode when xfs_balloon_get() refuses it Denis V. Lunev
2026-11-11 11:35   ` no-reply
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 4/5] ext4: discard the balloon on FITRIM Denis V. Lunev
2026-11-11 11:40   ` no-reply
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 5/5] xfs: " Denis V. Lunev
2026-11-11 11:40   ` no-reply
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-12 12:07 ` [Devel] [PATCH hci-8.1 v3 0/5] ext4, " Konstantin Khorenko
2026-11-12 12:08 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1ca6406bf-e60f3af0-b8a4-4709-bb16-0994d7c1ef56-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=den@openvz.org \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.