All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v3 0/5] ext4, xfs: discard the balloon on FITRIM
Date: Thu, 12 Nov 2026 13:07:44 +0100	[thread overview]
Message-ID: <179448526421.4060562.948782930462115219.b4-review@b4> (raw)
In-Reply-To: <20261111113135.4023555-1-den@openvz.org>

Applying with these fixes on my side:
- 3/5: added Fixes: 3681ad22775c ("xfs: Teach the fs where the balloon
  inode is"), and mount and remount added to the list of leaking calls
- 4/5, 5/5: "opened only through ..._OPEN_BALLOON, which takes
  CAP_SYS_ADMIN" reworded: a file handle opens the balloon too
- 4/5, 5/5: "Physically adjacent extents are merged" -> "Extents that
  follow each other both in the file and on disk are merged"

On Wed, 11 Nov 2026 12:31:30 +0100, Denis V. Lunev wrote:
> Daejun Park (2):
>   ms/xfs: don't skip free extents in later batches of a whole-AG FITRIM
>   ms/xfs: don't skip free extents of the longest length in a whole-AG
>     FITRIM
>
> Denis V. Lunev (3):
>   xfs: release the balloon inode when xfs_balloon_get() refuses it
>   ext4: discard the balloon on FITRIM
>   xfs: discard the balloon on FITRIM

Separate patches, not needed for this series; I created a task for
each:

1. A balloon discard error fails FITRIM, while both file systems
   ignore discard errors in the free space pass. ploop_trim() then
   stops and skips its smaller minlen rounds, which worked before this
   series. Please say whether that difference is wanted; if not, treat
   a balloon discard error the way the free space pass does.
   https://virtuozzo.atlassian.net/browse/VSTOR-154840

2. The chunks end on multiples of the discard granularity counted
   from the partition start, but the block layer aligns discards to
   the start of the whole disk. On a partition that does not start on
   a cluster boundary every chunk boundary splits a cluster, and ploop
   keeps it mapped. Partitions made by ploop start at one cluster, so
   this is minor: add the partition start to the remainder, or narrow
   the comment.
   https://virtuozzo.atlassian.net/browse/VSTOR-154841

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-12 12:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 11:31 Denis V. Lunev
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 1/5] ms/xfs: don't skip free extents in later batches of a whole-AG FITRIM Denis V. Lunev
2026-11-11 11:35   ` no-reply
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 2/5] ms/xfs: don't skip free extents of the longest length in " Denis V. Lunev
2026-11-11 11:35   ` no-reply
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 3/5] xfs: release the balloon inode when xfs_balloon_get() refuses it Denis V. Lunev
2026-11-11 11:35   ` no-reply
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 4/5] ext4: discard the balloon on FITRIM Denis V. Lunev
2026-11-11 11:40   ` no-reply
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 5/5] xfs: " Denis V. Lunev
2026-11-11 11:40   ` no-reply
2026-11-12 12:07   ` Konstantin Khorenko
2026-11-12 12:07 ` Konstantin Khorenko [this message]
2026-11-12 12:08 ` [Devel] [PATCH hci-8.1 v3 0/5] ext4, " Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179448526421.4060562.948782930462115219.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.