From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v3 5/5] xfs: discard the balloon on FITRIM
Date: Thu, 12 Nov 2026 13:07:44 +0100 [thread overview]
Message-ID: <179448526422.4060562.5815462477044375028.b4-review@b4> (raw)
In-Reply-To: <20261111113135.4023555-6-den@openvz.org>
Applying with these fixes on my side:
- "merging physically adjacent ones into one discard" -> "merging those
that follow each other both in the file and on disk into one
discard"
- "opened only through XFS_IOC_OPEN_BALLOON, which takes CAP_SYS_ADMIN,
so the locks only wait for ploop" -> "only a privileged process opens
it, through XFS_IOC_OPEN_BALLOON or a file handle, so in practice the
locks wait only for ploop"
On Wed, 11 Nov 2026 12:31:35 +0100, Denis V. Lunev wrote:
> its unwritten extents that fall into the requested range, merging
> physically adjacent ones into one discard. The walk goes to the end of
The run also ends at a hole, a written extent or an extent placed on
disk before the one before it in the file, the same as on ext4.
ploop fills the balloon from offset 0 and never writes it, so the
code is fine and only the wording changes.
> and opened only through XFS_IOC_OPEN_BALLOON, which takes
> CAP_SYS_ADMIN, so the locks only wait for ploop inflating or shrinking
> it.
open_by_handle_at() and XFS_IOC_OPEN_BY_HANDLE open the balloon too.
They need privileges as well, and the exclusive locks cover any opener,
so only the wording changes.
> + /*
> + * Chunks keep a long run interruptible. They end on multiples of the
> + * discard granularity, so no cluster below is split between two.
> + */
Item 2 of the cover letter reply.
> + error = blkdev_issue_discard(bdev, daddr, next - daddr,
> + GFP_KERNEL);
> + if (error)
> + return error;
Item 1 of the cover letter reply.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-12 12:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 11:31 [Devel] [PATCH hci-8.1 v3 0/5] ext4, " Denis V. Lunev
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 1/5] ms/xfs: don't skip free extents in later batches of a whole-AG FITRIM Denis V. Lunev
2026-11-11 11:35 ` no-reply
2026-11-12 12:07 ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 2/5] ms/xfs: don't skip free extents of the longest length in " Denis V. Lunev
2026-11-11 11:35 ` no-reply
2026-11-12 12:07 ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 3/5] xfs: release the balloon inode when xfs_balloon_get() refuses it Denis V. Lunev
2026-11-11 11:35 ` no-reply
2026-11-12 12:07 ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 4/5] ext4: discard the balloon on FITRIM Denis V. Lunev
2026-11-11 11:40 ` no-reply
2026-11-12 12:07 ` Konstantin Khorenko
2026-11-11 11:31 ` [Devel] [PATCH hci-8.1 v3 5/5] xfs: " Denis V. Lunev
2026-11-11 11:40 ` no-reply
2026-11-12 12:07 ` Konstantin Khorenko [this message]
2026-11-12 12:07 ` [Devel] [PATCH hci-8.1 v3 0/5] ext4, " Konstantin Khorenko
2026-11-12 12:08 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179448526422.4060562.5815462477044375028.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.