All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
* [Devel] [PATCH hci-8.2 v2 0/3] mm/memcontrol: tidy up the memory.numa_migrate code
@ 2026-11-17 16:24 Konstantin Khorenko
  2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 1/3] mm/memcontrol: drop the unused update_lru_sizes() Konstantin Khorenko
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Konstantin Khorenko @ 2026-11-17 16:24 UTC (permalink / raw)
  To: Pavel Tikhomirov, Vasileios Almpanis; +Cc: devel

Leftovers found while fixing VSTOR-151607, where the allocator of
memory.numa_migrate had fallen behind the upstream function it was
copied from. Nothing here changes behaviour.

- 1: update_lru_sizes() lost its only caller when the isolation loop
  switched to lruvec_del_folio(); static __always_inline, so no
  warning ever came.
- 2: the comment in the isolation loop told the rebase history of the
  code. It now names the upstream functions the loop and the allocator
  copy (isolate_migratepages_block(), isolate_lru_folios(),
  alloc_migration_target()), which is what the next rebase has to
  compare against. The commented-out conditions and the pre-folio name
  of the allocator go with it.
- 3: the comment of memcg_numa_isolate_pages() speaks of pages only,
  while the loop stops at @nr_to_scan folios scanned or @nr_to_scan
  pages isolated and returns the number of folios scanned.

https://virtuozzo.atlassian.net/browse/VSTOR-152197

Assisted-by: LLM
Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
Changes in v2:
- Rebased onto the current branch; the numa_migrate folio order series
  it applied on top of is in.
- 1: cite the commit id of the branch, 810e6836a6dc; Fixes: added, as
  Pavel suggested.
- 3: only the comment of memcg_numa_isolate_pages() changes, and it
  names both limits, folios scanned and pages isolated; the comments of
  memcg_numa_migrate_pages() and of MAX_SCAN stay as they were (Pavel).
- Link to v1: http://lore.virtuozzo.com/20261028-b4-prep-khorenko-vstor-152197-numa-migrate-cleanup-v1-0-aa959eecd3fd@virtuozzo.com

---
Konstantin Khorenko (3):
      mm/memcontrol: drop the unused update_lru_sizes()
      mm/memcontrol: say where the numa_migrate code comes from
      mm/memcontrol: say what memcg_numa_isolate_pages() limits

 mm/memcontrol.c | 49 +++++++++++--------------------------------------
 1 file changed, 11 insertions(+), 38 deletions(-)
---
base-commit: f386929460e779a18f354d1b01c051f8af1e5b41
change-id: 20261028-b4-prep-khorenko-vstor-152197-numa-migrate-cleanup-dcc488d8d106

Best regards,
--  
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-11-17 16:29 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 16:24 [Devel] [PATCH hci-8.2 v2 0/3] mm/memcontrol: tidy up the memory.numa_migrate code Konstantin Khorenko
2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 1/3] mm/memcontrol: drop the unused update_lru_sizes() Konstantin Khorenko
2026-11-17 16:27   ` no-reply
2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 2/3] mm/memcontrol: say where the numa_migrate code comes from Konstantin Khorenko
2026-11-17 16:28   ` no-reply
2026-11-17 16:24 ` [Devel] [PATCH hci-8.2 v2 3/3] mm/memcontrol: say what memcg_numa_isolate_pages() limits Konstantin Khorenko
2026-11-17 16:27   ` no-reply
2026-11-17 16:27 ` [Devel] [PATCH hci-8.2 v2 0/3] mm/memcontrol: tidy up the memory.numa_migrate code Konstantin Khorenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.