All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
* [Devel] [PATCH vz10] selftests/prctl: skip anon VMA naming test when unsupported
@ 2026-08-21 15:05 Eva Kurchatova
  2026-08-24 12:27 ` [Devel] [PATCH RHEL10 COMMIT] " Konstantin Khorenko
  2026-08-24 12:28 ` [Devel] [PATCH vz10] " Konstantin Khorenko
  0 siblings, 2 replies; 3+ messages in thread
From: Eva Kurchatova @ 2026-08-21 15:05 UTC (permalink / raw)


PR_SET_VMA_ANON_NAME returns EINVAL on kernels built without
CONFIG_ANON_VMA_NAME, and every renaming test then fails.

https://virtuozzo.atlassian.net/browse/VSTOR-142442
Feature: fix selftests
Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
---
 .../testing/selftests/prctl/set-anon-vma-name-test.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tools/testing/selftests/prctl/set-anon-vma-name-test.c b/tools/testing/selftests/prctl/set-anon-vma-name-test.c
index 4275cb256dce..815470c47aff 100644
--- a/tools/testing/selftests/prctl/set-anon-vma-name-test.c
+++ b/tools/testing/selftests/prctl/set-anon-vma-name-test.c
@@ -76,6 +76,18 @@ FIXTURE(vma) {
 };
 
 FIXTURE_SETUP(vma) {
+	void *probe;
+	int res;
+
+	/* Naming anonymous VMAs needs CONFIG_ANON_VMA_NAME. */
+	probe = mmap(NULL, AREA_SIZE, PROT_READ | PROT_WRITE,
+					MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
+	ASSERT_NE(probe, MAP_FAILED);
+	res = rename_vma((unsigned long)probe, AREA_SIZE, GOOD_NAME);
+	munmap(probe, AREA_SIZE);
+	if (res == -EINVAL)
+		SKIP(return, "CONFIG_ANON_VMA_NAME is not enabled");
+
 	self->ptr_anon = mmap(NULL, AREA_SIZE, PROT_READ | PROT_WRITE,
 					MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
 	ASSERT_NE(self->ptr_anon, NULL);
-- 
2.55.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Devel] [PATCH RHEL10 COMMIT] selftests/prctl: skip anon VMA naming test when unsupported
  2026-08-21 15:05 [Devel] [PATCH vz10] selftests/prctl: skip anon VMA naming test when unsupported Eva Kurchatova
@ 2026-08-24 12:27 ` Konstantin Khorenko
  2026-08-24 12:28 ` [Devel] [PATCH vz10] " Konstantin Khorenko
  1 sibling, 0 replies; 3+ messages in thread
From: Konstantin Khorenko @ 2026-08-24 12:27 UTC (permalink / raw)


The commit is pushed to "branch-rh10-6.12.0-211.39.1.16.x.vz10-ovz" and will appear at git at bitbucket.org:openvz/vzkernel.git
after rh10-6.12.0-211.39.1.16.8.vz10
------>
commit f08227f3caebac213f280c22b1f76086412909e0
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Date:   Fri Aug 21 18:05:20 2026 +0300

    selftests/prctl: skip anon VMA naming test when unsupported
    
    PR_SET_VMA_ANON_NAME returns EINVAL on kernels built without
    CONFIG_ANON_VMA_NAME, and every renaming test then fails.
    
    https://virtuozzo.atlassian.net/browse/VSTOR-142442
    Feature: fix selftests
    Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
    Reviewed-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
 tools/testing/selftests/prctl/set-anon-vma-name-test.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tools/testing/selftests/prctl/set-anon-vma-name-test.c b/tools/testing/selftests/prctl/set-anon-vma-name-test.c
index 4275cb256dce..815470c47aff 100644
--- a/tools/testing/selftests/prctl/set-anon-vma-name-test.c
+++ b/tools/testing/selftests/prctl/set-anon-vma-name-test.c
@@ -76,6 +76,18 @@ FIXTURE(vma) {
 };
 
 FIXTURE_SETUP(vma) {
+	void *probe;
+	int res;
+
+	/* Naming anonymous VMAs needs CONFIG_ANON_VMA_NAME. */
+	probe = mmap(NULL, AREA_SIZE, PROT_READ | PROT_WRITE,
+					MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
+	ASSERT_NE(probe, MAP_FAILED);
+	res = rename_vma((unsigned long)probe, AREA_SIZE, GOOD_NAME);
+	munmap(probe, AREA_SIZE);
+	if (res == -EINVAL)
+		SKIP(return, "CONFIG_ANON_VMA_NAME is not enabled");
+
 	self->ptr_anon = mmap(NULL, AREA_SIZE, PROT_READ | PROT_WRITE,
 					MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
 	ASSERT_NE(self->ptr_anon, NULL);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Devel] [PATCH vz10] selftests/prctl: skip anon VMA naming test when unsupported
  2026-08-21 15:05 [Devel] [PATCH vz10] selftests/prctl: skip anon VMA naming test when unsupported Eva Kurchatova
  2026-08-24 12:27 ` [Devel] [PATCH RHEL10 COMMIT] " Konstantin Khorenko
@ 2026-08-24 12:28 ` Konstantin Khorenko
  1 sibling, 0 replies; 3+ messages in thread
From: Konstantin Khorenko @ 2026-08-24 12:28 UTC (permalink / raw)


1. ack the patch

2. do not forget to remove the kludge in hci-kselftests:
  # prctl set-anon-vma-name-test test fails because CONFIG_ANON_VMA_NAME
  # is not enabled
  'prctl': ['set-anon-vma-name-test'],

3. There are 2 more bugs nearby, please fix them and send to ms as well:

In tools/testing/selftests/prctl/set-anon-vma-name-test.c,
FIXTURE_SETUP(vma) checks both mmap() results against NULL, but mmap() fails with MAP_FAILED, so neither ASSERT_NE() can ever fire.

        ASSERT_NE(self->ptr_anon, NULL);
        ASSERT_NE(self->ptr_not_anon, NULL);

--
Best regards,

Konstantin Khorenko,
Virtuozzo Linux Kernel Team

On 8/21/26 17:05, Eva Kurchatova wrote:
> PR_SET_VMA_ANON_NAME returns EINVAL on kernels built without
> CONFIG_ANON_VMA_NAME, and every renaming test then fails.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-142442
> Feature: fix selftests
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
> ---
>  .../testing/selftests/prctl/set-anon-vma-name-test.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/tools/testing/selftests/prctl/set-anon-vma-name-test.c b/tools/testing/selftests/prctl/set-anon-vma-name-test.c
> index 4275cb256dce..815470c47aff 100644
> --- a/tools/testing/selftests/prctl/set-anon-vma-name-test.c
> +++ b/tools/testing/selftests/prctl/set-anon-vma-name-test.c
> @@ -76,6 +76,18 @@ FIXTURE(vma) {
>  };
>  
>  FIXTURE_SETUP(vma) {
> +	void *probe;
> +	int res;
> +
> +	/* Naming anonymous VMAs needs CONFIG_ANON_VMA_NAME. */
> +	probe = mmap(NULL, AREA_SIZE, PROT_READ | PROT_WRITE,
> +					MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
> +	ASSERT_NE(probe, MAP_FAILED);
> +	res = rename_vma((unsigned long)probe, AREA_SIZE, GOOD_NAME);
> +	munmap(probe, AREA_SIZE);
> +	if (res == -EINVAL)
> +		SKIP(return, "CONFIG_ANON_VMA_NAME is not enabled");
> +
>  	self->ptr_anon = mmap(NULL, AREA_SIZE, PROT_READ | PROT_WRITE,
>  					MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
>  	ASSERT_NE(self->ptr_anon, NULL);


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-24 12:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-21 15:05 [Devel] [PATCH vz10] selftests/prctl: skip anon VMA naming test when unsupported Eva Kurchatova
2026-08-24 12:27 ` [Devel] [PATCH RHEL10 COMMIT] " Konstantin Khorenko
2026-08-24 12:28 ` [Devel] [PATCH vz10] " Konstantin Khorenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.