All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
* [PATCH hci-8.1 0/2] i386: fix the exec slowdown of pc-q35-vz10.1.0 guests #VSTOR-154986
@ 2026-11-16 17:50 Denis V. Lunev
  2026-11-16 17:50 ` [PATCH hci-8.1 1/2] i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986 Denis V. Lunev
  2026-11-16 17:50 ` [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986 Denis V. Lunev
  0 siblings, 2 replies; 7+ messages in thread
From: Denis V. Lunev @ 2026-11-16 17:50 UTC (permalink / raw)
  To: svt-core; +Cc: andrey.drobyshev, den

HCI 8.1 guests run fork/exec heavy work about 10% slower than on 8.0.
perf-atomic showed it in all five 8.0 vs 8.1 comparisons on four HDD
nodes: unixbench execl -10.4% to -14.7%, syscall/sysexec (which are
really fork+exec) -8.6% to -12.1%, cpu-ins -5%. The host is not the
cause. 8.1 nova creates VMs with pc-q35-vz10.1.0 where 8.0 used
pc-q35-vz10.0.0, and the new machine type changes two things the guest
sees: CPUID leaf 2 reports 0xff, so glibc's cache queries at process
start cost twice the CPUID exits, and la57 is no longer hidden, so
Linux guests boot with 5-level paging.

The series turns both off on pc-q35-vz10.1.0, so it gives the guest the
same CPU as pc-q35-vz10.0.0.

The trade-off: a vz10.1.0 guest no longer gets la57 on a fresh start,
"-cpu host" included, unless it asks for it with la57=on. Our guests
do not need a 57-bit address space.

This is for hci-8.1 only. hci-dev is identical to hci-8.1 at the moment,
so the patches apply there as is. The 8.0 QEMU defines pc-q35-vz10.1.0
too and keeps it unchanged, but nova on 8.0 pins pc-q35-vz10.0.0.

Tested with the qemu-kvm-10.1.0-20.vz10.23 SRPM rebuilt with both
patches on hw-hdd01 (HCI 8.1.0-227, Xeon Silver 4314). A minimal guest
with the perf guest kernel (6.12.0-211.74.2.el10_2), Icelake-Server,
pinned to one vCPU:

                       execl/s  fork+exec/s  insb/s  CPUID exits per run
  vz10.1.0, stock 8.1    3400       2675      217K         11.85M
  vz10.1.0, patched      3890       2985      228K          6.83M
  vz10.0.0, patched      3890       2990      229K          6.84M

The perf VM itself, hard rebooted through nova on the patched QEMU,
starts with la57 disabled in its live libvirt definition, boots with
48-bit virtual addresses and runs execl at ~3995/s against 3312/s
before (3667/s on the 8.0 node).

RCA and all comparisons are in VSTOR-154986:

  https://virtuozzo.atlassian.net/browse/VSTOR-154986

Denis V. Lunev (2):
  i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986
  i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986

 hw/i386/pc.c         | 5 +++--
 hw/i386/pc_piix.c    | 2 +-
 hw/i386/pc_q35.c     | 4 ++--
 include/hw/i386/pc.h | 4 ++--
 target/i386/cpu.h    | 2 +-
 5 files changed, 9 insertions(+), 8 deletions(-)


base-commit: ac2ba825418b2726a7a4f367f8ef6d69d8563e47
-- 
2.55.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH hci-8.1 1/2] i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986
  2026-11-16 17:50 [PATCH hci-8.1 0/2] i386: fix the exec slowdown of pc-q35-vz10.1.0 guests #VSTOR-154986 Denis V. Lunev
@ 2026-11-16 17:50 ` Denis V. Lunev
  2026-11-16 17:53   ` no-reply
  2026-11-17 17:03   ` Andrey Drobyshev
  2026-11-16 17:50 ` [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986 Denis V. Lunev
  1 sibling, 2 replies; 7+ messages in thread
From: Denis V. Lunev @ 2026-11-16 17:50 UTC (permalink / raw)
  To: svt-core; +Cc: andrey.drobyshev, den

From: Denis V. Lunev <den@openvz.org>

pc-q35-vz10.1.0 is based on rhel10.2.0 and so takes the upstream default
of x-consistent-cache from 6699e5dc864 ("i386/cpu: Present same cache
model in CPUID 0x2 & 0x4"). CPUID leaf 2 then reports 0xff, "use leaf
4", instead of legacy descriptors. glibc reads leaf 2 for each of its
cache queries at every process start, and with 0xff each read walks the
leaf 4 subleaves. Under KVM every CPUID is a VM exit, so a vz10.1.0
guest takes many more CPUID exits per exec than a vz10.0.0 one, and
fork/exec heavy workloads (unixbench execl, spawn and shell) regress.

Neither cache model describes the host, both are synthetic, so the new
one buys the guest nothing. Turn it off as vz10.0.0 and rhel10.0.0 do.

The guest reads leaf 2 at boot and glibc at process start, so a running
vz10.1.0 guest migrated to a node with this change keeps working, new
processes just see the old descriptors.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 hw/i386/pc.c         | 5 +++++
 hw/i386/pc_q35.c     | 2 +-
 include/hw/i386/pc.h | 3 +++
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 2834982dab4..8b39c5621c6 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -548,6 +548,11 @@ GlobalProperty pc_vz_compat[] = {
 };
 const size_t pc_vz_compat_len = G_N_ELEMENTS(pc_vz_compat);
 
+GlobalProperty pc_vz_10_1_compat[] = {
+    { TYPE_X86_CPU, "x-consistent-cache", "false" },
+};
+const size_t pc_vz_10_1_compat_len = G_N_ELEMENTS(pc_vz_10_1_compat);
+
 GlobalProperty pc_vz_10_0_compat[] = {
     { TYPE_X86_CPU, "x-no-la57-on-start", "on" },
 };
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 51539f22399..ae8298e0503 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -972,7 +972,7 @@ DEFINE_Q35_RHEL_MACHINE(7, 3, 0);
 
 /*  maj min mic         basemt      isdefault                              */
 #define VZ_Q35_MT(X)                                                        \
-    X(10, 1, 0, MT_VER_SYM(10, 2, 0), true)                                 \
+    X(10, 1, 0, MT_VER_SYM(10, 2, 0), true,  pc_vz_10_1_compat)             \
     X(10, 0, 0, MT_VER_SYM(10, 0, 0), false, pc_vz_10_0_compat)             \
     X(9, 2,  0, MT_VER_SYM(9, 6, 0),  false, pc_vz_9_2_compat)              \
     X(9, 1,  0, MT_VER_SYM(9, 4, 0),  false, hw_compat_vz_9_1)              \
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 021b139b872..276d0cdb3fa 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -364,6 +364,9 @@ extern const size_t pc_rhel_7_2_compat_len;
 extern GlobalProperty pc_vz_compat[];
 extern const size_t pc_vz_compat_len;
 
+extern GlobalProperty pc_vz_10_1_compat[];
+extern const size_t pc_vz_10_1_compat_len;
+
 extern GlobalProperty pc_vz_10_0_compat[];
 extern const size_t pc_vz_10_0_compat_len;
 
-- 
2.55.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986
  2026-11-16 17:50 [PATCH hci-8.1 0/2] i386: fix the exec slowdown of pc-q35-vz10.1.0 guests #VSTOR-154986 Denis V. Lunev
  2026-11-16 17:50 ` [PATCH hci-8.1 1/2] i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986 Denis V. Lunev
@ 2026-11-16 17:50 ` Denis V. Lunev
  2026-11-16 17:53   ` no-reply
  2026-11-17 17:03   ` Andrey Drobyshev
  1 sibling, 2 replies; 7+ messages in thread
From: Denis V. Lunev @ 2026-11-16 17:50 UTC (permalink / raw)
  To: svt-core; +Cc: andrey.drobyshev, den

From: Denis V. Lunev <den@openvz.org>

x-no-la57-on-start covers pc-q35-vz10.0.0 and older and every
pc-i440fx type, but not pc-q35-vz10.1.0. A Linux guest built with
CONFIG_X86_5LEVEL switches to 5-level paging whenever the CPU reports
la57, whatever its RAM size, so on hosts with la57 (Ice Lake SP and
newer, EPYC 9004/9005) every vz10.1.0 guest gets the extra page table
level. That lengthens the KVM software walk of guest page tables used
by emulated string I/O, and adds to page table setup and teardown in
every exec.

Our guests do not need a 57-bit address space. Hide la57 on
pc-q35-vz10.1.0 as well. pc_vz_10_0_compat is left with nothing of its
own, so fold it into pc_vz_10_1_compat. A guest that needs la57 gets
it only with la57=on, "-cpu host" included. A running guest keeps la57
on incoming migration.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 hw/i386/pc.c         | 6 +-----
 hw/i386/pc_piix.c    | 2 +-
 hw/i386/pc_q35.c     | 2 +-
 include/hw/i386/pc.h | 3 ---
 target/i386/cpu.h    | 2 +-
 5 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 8b39c5621c6..797a0b22184 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -550,13 +550,9 @@ const size_t pc_vz_compat_len = G_N_ELEMENTS(pc_vz_compat);
 
 GlobalProperty pc_vz_10_1_compat[] = {
     { TYPE_X86_CPU, "x-consistent-cache", "false" },
-};
-const size_t pc_vz_10_1_compat_len = G_N_ELEMENTS(pc_vz_10_1_compat);
-
-GlobalProperty pc_vz_10_0_compat[] = {
     { TYPE_X86_CPU, "x-no-la57-on-start", "on" },
 };
-const size_t pc_vz_10_0_compat_len = G_N_ELEMENTS(pc_vz_10_0_compat);
+const size_t pc_vz_10_1_compat_len = G_N_ELEMENTS(pc_vz_10_1_compat);
 
 GlobalProperty pc_vz_9_2_compat[] = {
     { TYPE_X86_CPU, "x-tsx-compat", "on" },
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 768c6e47f53..4e350e8cc35 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -1056,7 +1056,7 @@ DEFINE_I440FX_RHEL_MACHINE(7, 2, 0);
 
 /*  maj min mic         basemt      isdefault                              */
 #define VZ_PC_MT(X) \
-    X(10, 1, 0, MT_VER_SYM(10, 0, 0), true,  pc_vz_10_0_compat)             \
+    X(10, 1, 0, MT_VER_SYM(10, 0, 0), true,  pc_vz_10_1_compat)             \
     X(10, 0, 0, MT_VER_SYM(10, 0, 0), false)                                \
     X(7, 16, 0, MT_VER_SYM(7, 6, 0),  false, pc_vz_9_2_compat,              \
                                              hw_compat_vz_9_1,              \
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index ae8298e0503..89f8def8cd4 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -973,7 +973,7 @@ DEFINE_Q35_RHEL_MACHINE(7, 3, 0);
 /*  maj min mic         basemt      isdefault                              */
 #define VZ_Q35_MT(X)                                                        \
     X(10, 1, 0, MT_VER_SYM(10, 2, 0), true,  pc_vz_10_1_compat)             \
-    X(10, 0, 0, MT_VER_SYM(10, 0, 0), false, pc_vz_10_0_compat)             \
+    X(10, 0, 0, MT_VER_SYM(10, 0, 0), false)                                \
     X(9, 2,  0, MT_VER_SYM(9, 6, 0),  false, pc_vz_9_2_compat)              \
     X(9, 1,  0, MT_VER_SYM(9, 4, 0),  false, hw_compat_vz_9_1)              \
     X(9, 0,  0, MT_VER_SYM(9, 2, 0),  false)                                \
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 276d0cdb3fa..cceff5345e7 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -367,9 +367,6 @@ extern const size_t pc_vz_compat_len;
 extern GlobalProperty pc_vz_10_1_compat[];
 extern const size_t pc_vz_10_1_compat_len;
 
-extern GlobalProperty pc_vz_10_0_compat[];
-extern const size_t pc_vz_10_0_compat_len;
-
 extern GlobalProperty pc_vz_9_2_compat[];
 extern const size_t pc_vz_9_2_compat_len;
 
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index cbea9cf63d9..05ea4808237 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -2343,7 +2343,7 @@ struct ArchCPU {
     bool svm_features_compat;
 
     /*
-     * Virtuozzo machine types up to vz10.0.0: hide la57 unless requested
+     * Virtuozzo machine types up to vz10.1.0: hide la57 unless requested
      * explicitly when the VM starts fresh, keep it on incoming migration.
      */
     bool no_la57_on_start;
-- 
2.55.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH hci-8.1 1/2] i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986
  2026-11-16 17:50 ` [PATCH hci-8.1 1/2] i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986 Denis V. Lunev
@ 2026-11-16 17:53   ` no-reply
  2026-11-17 17:03   ` Andrey Drobyshev
  1 sibling, 0 replies; 7+ messages in thread
From: no-reply @ 2026-11-16 17:53 UTC (permalink / raw)
  To: Denis V. Lunev, svt-core; +Cc: andrey.drobyshev

> From: Denis V. Lunev <den@openvz.org>
> 
> pc-q35-vz10.1.0 is based on rhel10.2.0 and so takes the upstream default
> of x-consistent-cache from 6699e5dc864 ("i386/cpu: Present same cache
> model in CPUID 0x2 & 0x4"). CPUID leaf 2 then reports 0xff, "use leaf
> 4", instead of legacy descriptors. glibc reads leaf 2 for each of its
> cache queries at every process start, and with 0xff each read walks the
> leaf 4 subleaves. Under KVM every CPUID is a VM exit, so a vz10.1.0
> guest takes many more CPUID exits per exec than a vz10.0.0 one, and
> fork/exec heavy workloads (unixbench execl, spawn and shell) regress.
> 
> Neither cache model describes the host, both are synthetic, so the new
> one buys the guest nothing. Turn it off as vz10.0.0 and rhel10.0.0 do.
> 
> The guest reads leaf 2 at boot and glibc at process start, so a running
> vz10.1.0 guest migrated to a node with this change keeps working, new
> processes just see the old descriptors.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116175002.844361-1-den@openvz.org?part=1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986
  2026-11-16 17:50 ` [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986 Denis V. Lunev
@ 2026-11-16 17:53   ` no-reply
  2026-11-17 17:03   ` Andrey Drobyshev
  1 sibling, 0 replies; 7+ messages in thread
From: no-reply @ 2026-11-16 17:53 UTC (permalink / raw)
  To: Denis V. Lunev, svt-core; +Cc: andrey.drobyshev

> From: Denis V. Lunev <den@openvz.org>
> 
> x-no-la57-on-start covers pc-q35-vz10.0.0 and older and every
> pc-i440fx type, but not pc-q35-vz10.1.0. A Linux guest built with
> CONFIG_X86_5LEVEL switches to 5-level paging whenever the CPU reports
> la57, whatever its RAM size, so on hosts with la57 (Ice Lake SP and
> newer, EPYC 9004/9005) every vz10.1.0 guest gets the extra page table
> level. That lengthens the KVM software walk of guest page tables used
> by emulated string I/O, and adds to page table setup and teardown in
> every exec.
> 
> Our guests do not need a 57-bit address space. Hide la57 on
> pc-q35-vz10.1.0 as well. pc_vz_10_0_compat is left with nothing of its
> own, so fold it into pc_vz_10_1_compat. A guest that needs la57 gets
> it only with la57=on, "-cpu host" included. A running guest keeps la57
> on incoming migration.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116175002.844361-1-den@openvz.org?part=2


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH hci-8.1 1/2] i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986
  2026-11-16 17:50 ` [PATCH hci-8.1 1/2] i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986 Denis V. Lunev
  2026-11-16 17:53   ` no-reply
@ 2026-11-17 17:03   ` Andrey Drobyshev
  1 sibling, 0 replies; 7+ messages in thread
From: Andrey Drobyshev @ 2026-11-17 17:03 UTC (permalink / raw)
  To: Denis V. Lunev, svt-core

On 11/16/26 7:50 PM, Denis V. Lunev wrote:
> From: Denis V. Lunev <den@openvz.org>
> 
> pc-q35-vz10.1.0 is based on rhel10.2.0 and so takes the upstream default
> of x-consistent-cache from 6699e5dc864 ("i386/cpu: Present same cache
> model in CPUID 0x2 & 0x4"). CPUID leaf 2 then reports 0xff, "use leaf
> 4", instead of legacy descriptors. glibc reads leaf 2 for each of its
> cache queries at every process start, and with 0xff each read walks the
> leaf 4 subleaves. Under KVM every CPUID is a VM exit, so a vz10.1.0
> guest takes many more CPUID exits per exec than a vz10.0.0 one, and
> fork/exec heavy workloads (unixbench execl, spawn and shell) regress.
> 
> Neither cache model describes the host, both are synthetic, so the new
> one buys the guest nothing. Turn it off as vz10.0.0 and rhel10.0.0 do.
> 
> The guest reads leaf 2 at boot and glibc at process start, so a running
> vz10.1.0 guest migrated to a node with this change keeps working, new
> processes just see the old descriptors.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
>  hw/i386/pc.c         | 5 +++++
>  hw/i386/pc_q35.c     | 2 +-
>  include/hw/i386/pc.h | 3 +++
>  3 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 2834982dab4..8b39c5621c6 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -548,6 +548,11 @@ GlobalProperty pc_vz_compat[] = {
>  };
>  const size_t pc_vz_compat_len = G_N_ELEMENTS(pc_vz_compat);
>  
> +GlobalProperty pc_vz_10_1_compat[] = {
> +    { TYPE_X86_CPU, "x-consistent-cache", "false" },
> +};
> +const size_t pc_vz_10_1_compat_len = G_N_ELEMENTS(pc_vz_10_1_compat);

LGTM overall.  However IIUC we want this disabled for ALL our MTs, not
just 10.1 and older.  If so, and if we want to avoid rebase artifacts -
better move it into pc_vz_compat.

Andrey

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986
  2026-11-16 17:50 ` [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986 Denis V. Lunev
  2026-11-16 17:53   ` no-reply
@ 2026-11-17 17:03   ` Andrey Drobyshev
  1 sibling, 0 replies; 7+ messages in thread
From: Andrey Drobyshev @ 2026-11-17 17:03 UTC (permalink / raw)
  To: Denis V. Lunev, svt-core

On 11/16/26 7:50 PM, Denis V. Lunev wrote:
> From: Denis V. Lunev <den@openvz.org>
> 
> x-no-la57-on-start covers pc-q35-vz10.0.0 and older and every
> pc-i440fx type, but not pc-q35-vz10.1.0. A Linux guest built with
> CONFIG_X86_5LEVEL switches to 5-level paging whenever the CPU reports
> la57, whatever its RAM size, so on hosts with la57 (Ice Lake SP and
> newer, EPYC 9004/9005) every vz10.1.0 guest gets the extra page table
> level. That lengthens the KVM software walk of guest page tables used
> by emulated string I/O, and adds to page table setup and teardown in
> every exec.
> 
> Our guests do not need a 57-bit address space. Hide la57 on
> pc-q35-vz10.1.0 as well. pc_vz_10_0_compat is left with nothing of its
> own, so fold it into pc_vz_10_1_compat. A guest that needs la57 gets
> it only with la57=on, "-cpu host" included. A running guest keeps la57
> on incoming migration.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
>  hw/i386/pc.c         | 6 +-----
>  hw/i386/pc_piix.c    | 2 +-
>  hw/i386/pc_q35.c     | 2 +-
>  include/hw/i386/pc.h | 3 ---
>  target/i386/cpu.h    | 2 +-
>  5 files changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 8b39c5621c6..797a0b22184 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -550,13 +550,9 @@ const size_t pc_vz_compat_len = G_N_ELEMENTS(pc_vz_compat);
>  
>  GlobalProperty pc_vz_10_1_compat[] = {
>      { TYPE_X86_CPU, "x-consistent-cache", "false" },
> -};
> -const size_t pc_vz_10_1_compat_len = G_N_ELEMENTS(pc_vz_10_1_compat);
> -
> -GlobalProperty pc_vz_10_0_compat[] = {
>      { TYPE_X86_CPU, "x-no-la57-on-start", "on" },
>  };
> -const size_t pc_vz_10_0_compat_len = G_N_ELEMENTS(pc_vz_10_0_compat);
> +const size_t pc_vz_10_1_compat_len = G_N_ELEMENTS(pc_vz_10_1_compat);

Same here. Looks like we might want to set x-no-la57-on-start=on for all
VZ MTs.  If so - let's move it into pc_vz_compat so it doesn't get
missed on the next rebase.

Also subject line is misleading as it's not only q35, but pc as well.

>  GlobalProperty pc_vz_9_2_compat[] = {
>      { TYPE_X86_CPU, "x-tsx-compat", "on" },
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 768c6e47f53..4e350e8cc35 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -1056,7 +1056,7 @@ DEFINE_I440FX_RHEL_MACHINE(7, 2, 0);
>  
>  /*  maj min mic         basemt      isdefault                              */
>  #define VZ_PC_MT(X) \
> -    X(10, 1, 0, MT_VER_SYM(10, 0, 0), true,  pc_vz_10_0_compat)             \
> +    X(10, 1, 0, MT_VER_SYM(10, 0, 0), true,  pc_vz_10_1_compat)             \
>      X(10, 0, 0, MT_VER_SYM(10, 0, 0), false)                                \
>      X(7, 16, 0, MT_VER_SYM(7, 6, 0),  false, pc_vz_9_2_compat,              \
>                                               hw_compat_vz_9_1,              \
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index ae8298e0503..89f8def8cd4 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -973,7 +973,7 @@ DEFINE_Q35_RHEL_MACHINE(7, 3, 0);
>  /*  maj min mic         basemt      isdefault                              */
>  #define VZ_Q35_MT(X)                                                        \
>      X(10, 1, 0, MT_VER_SYM(10, 2, 0), true,  pc_vz_10_1_compat)             \
> -    X(10, 0, 0, MT_VER_SYM(10, 0, 0), false, pc_vz_10_0_compat)             \
> +    X(10, 0, 0, MT_VER_SYM(10, 0, 0), false)                                \
>      X(9, 2,  0, MT_VER_SYM(9, 6, 0),  false, pc_vz_9_2_compat)              \
>      X(9, 1,  0, MT_VER_SYM(9, 4, 0),  false, hw_compat_vz_9_1)              \
>      X(9, 0,  0, MT_VER_SYM(9, 2, 0),  false)                                \
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 276d0cdb3fa..cceff5345e7 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -367,9 +367,6 @@ extern const size_t pc_vz_compat_len;
>  extern GlobalProperty pc_vz_10_1_compat[];
>  extern const size_t pc_vz_10_1_compat_len;
>  
> -extern GlobalProperty pc_vz_10_0_compat[];
> -extern const size_t pc_vz_10_0_compat_len;
> -
>  extern GlobalProperty pc_vz_9_2_compat[];
>  extern const size_t pc_vz_9_2_compat_len;
>  
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index cbea9cf63d9..05ea4808237 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -2343,7 +2343,7 @@ struct ArchCPU {
>      bool svm_features_compat;
>  
>      /*
> -     * Virtuozzo machine types up to vz10.0.0: hide la57 unless requested
> +     * Virtuozzo machine types up to vz10.1.0: hide la57 unless requested

If we move the prop into pc_vz_compat - this comment shouldn't mention
versions.

Andrey

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-17 17:03 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 17:50 [PATCH hci-8.1 0/2] i386: fix the exec slowdown of pc-q35-vz10.1.0 guests #VSTOR-154986 Denis V. Lunev
2026-11-16 17:50 ` [PATCH hci-8.1 1/2] i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986 Denis V. Lunev
2026-11-16 17:53   ` no-reply
2026-11-17 17:03   ` Andrey Drobyshev
2026-11-16 17:50 ` [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986 Denis V. Lunev
2026-11-16 17:53   ` no-reply
2026-11-17 17:03   ` Andrey Drobyshev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.