OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
* [Devel] [PATCH vz10] selftests: pidfd: add a settings file with a longer timeout
@ 2026-09-16 12:10 Eva Kurchatova
  2026-09-16 16:55 ` Konstantin Khorenko
  2026-09-16 16:56 ` Konstantin Khorenko
  0 siblings, 2 replies; 3+ messages in thread
From: Eva Kurchatova @ 2026-09-16 12:10 UTC (permalink / raw)
  To: khorenko; +Cc: devel

pidfd_test has no settings file, so it gets the 45 second default.

On a two cpu node with a coverage kernel it takes over 50 seconds, avg
three runs, so it is killed just before it would have passed:

  not ok 1 selftests: pidfd: pidfd_test # TIMEOUT 45 seconds

Ask for 300 seconds, as cgroup and kmod already do for the same reason.
The test passes in every one of those runs; only the limit is wrong.

https://virtuozzo.atlassian.net/browse/VSTOR-139651

Feature: fix selftests
Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
---
 tools/testing/selftests/pidfd/settings | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 tools/testing/selftests/pidfd/settings

diff --git a/tools/testing/selftests/pidfd/settings b/tools/testing/selftests/pidfd/settings
new file mode 100644
index 000000000000..694d70710ff0
--- /dev/null
+++ b/tools/testing/selftests/pidfd/settings
@@ -0,0 +1 @@
+timeout=300
-- 
2.55.0

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Devel] [PATCH vz10] selftests: pidfd: add a settings file with a longer timeout
  2026-09-16 12:10 [Devel] [PATCH vz10] selftests: pidfd: add a settings file with a longer timeout Eva Kurchatova
@ 2026-09-16 16:55 ` Konstantin Khorenko
  2026-09-16 16:56 ` Konstantin Khorenko
  1 sibling, 0 replies; 3+ messages in thread
From: Konstantin Khorenko @ 2026-09-16 16:55 UTC (permalink / raw)
  To: Eva Kurchatova; +Cc: devel

> The pidfd directory has no settings file, so every test in it gets the
> 45 second default. On a slow node with a coverage kernel pidfd_test
> runs past that and is killed while it is still passing:
> 
>   not ok 1 selftests: pidfd: pidfd_test # TIMEOUT 45 seconds
> 
> Ask for 300 seconds, as cgroup and kmod already do. The setting is per
> directory, so the other pidfd tests get the same limit.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-139651
> 
> Feature: fix selftests
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

i've changed commit message a bit, but overall - ack.

>
> diff --git a/tools/testing/selftests/pidfd/settings b/tools/testing/selftests/pidfd/settings
> new file mode 100644
> index 0000000000000..694d70710ff08
> --- /dev/null
> +++ b/tools/testing/selftests/pidfd/settings
> @@ -0,0 +1 @@
> +timeout=300

Reviewed-by: Konstantin Khorenko <khorenko@virtuozzo.com>

-- 
Konstantin Khorenko <khorenko@virtuozzo.com>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Devel] [PATCH vz10] selftests: pidfd: add a settings file with a longer timeout
  2026-09-16 12:10 [Devel] [PATCH vz10] selftests: pidfd: add a settings file with a longer timeout Eva Kurchatova
  2026-09-16 16:55 ` Konstantin Khorenko
@ 2026-09-16 16:56 ` Konstantin Khorenko
  1 sibling, 0 replies; 3+ messages in thread
From: Konstantin Khorenko @ 2026-09-16 16:56 UTC (permalink / raw)
  To: Eva Kurchatova; +Cc: devel

On Wed, 16 Sep 2026 15:10:41 +0300, Eva Kurchatova wrote:
> selftests: pidfd: add a settings file with a longer timeout

Applied to branch-rh10-6.12.0-211.52.1.20.x.vz10-ovz, will be released in rh10-6.12.0-211.52.1.20.6.vz10, thanks!

[1/1] selftests: pidfd: add a settings file with a longer timeout
      https://bitbucket.org/virtuozzocore/vzkernel.vzs/commits/adabd922c002

-- 
Konstantin Khorenko <khorenko@virtuozzo.com>

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-16 16:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-16 12:10 [Devel] [PATCH vz10] selftests: pidfd: add a settings file with a longer timeout Eva Kurchatova
2026-09-16 16:55 ` Konstantin Khorenko
2026-09-16 16:56 ` Konstantin Khorenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox