From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 4/6] timens: freeze the offsets on the first join without the vDSO too
Date: Tue, 20 Oct 2026 18:13:09 +0200 [thread overview]
Message-ID: <179251278950.3723285.3438661902523691061.b4-review@b4> (raw)
In-Reply-To: <20261019000649.1371025-5-eva.kurchatova@virtuozzo.com>
> A time namespace's offsets may be written until the first task joins
> it; from then on they are read without a lock, so that join freezes
> them. The freeze sat in the code that fills the namespace's vDSO
> page, and since 1b6c89285d37 ("timens: Remove dependency on the vDSO")
> a kernel without a generic vDSO, User Mode Linux now, never froze: the
> owner could rewrite the offsets under the tasks already running there,
> and the clocks they read moved with them.
>
> Freeze in timens_commit() itself and fill the vDSO page from there,
> where there is one.
Looks like this patch fixes the problem which exists in the mainstream as well,
so please
- file a task and post it here for sending this patch to mainstream
- send the patch to the mainstream, get the feedback
- once mainstream applies the commit to some git tree - even unstable,
resend this commit as a backport, i will apply it as well.
i.e. work in the "mainsteam first" for this commit.
You can send a next version of the series without this patch, i will take them.
--
Konstantin Khorenko <khorenko@virtuozzo.com>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-10-20 16:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 0:05 [Devel] [PATCH hci-8.1 v2 0/6] timens: Remove dependency on the vDSO Eva Kurchatova
2026-10-19 0:05 ` [Devel] [PATCH hci-8.1 v2 1/6] ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS Eva Kurchatova
2026-10-19 0:12 ` no-reply
2026-10-20 16:13 ` Konstantin Khorenko
2026-10-19 0:05 ` [Devel] [PATCH hci-8.1 v2 2/6] ms/vdso/timens: Move functions to new file Eva Kurchatova
2026-10-19 0:12 ` no-reply
2026-10-20 16:13 ` Konstantin Khorenko
2026-10-19 0:05 ` [Devel] [PATCH hci-8.1 v2 3/6] ms/timens: Remove dependency on the vDSO Eva Kurchatova
2026-10-19 0:15 ` no-reply
2026-10-20 16:13 ` Konstantin Khorenko
2026-10-19 0:05 ` [Devel] [PATCH hci-8.1 v2 4/6] timens: freeze the offsets on the first join without the vDSO too Eva Kurchatova
2026-10-19 0:14 ` no-reply
2026-10-20 16:13 ` Konstantin Khorenko [this message]
2026-10-19 0:05 ` [Devel] [PATCH hci-8.1 v2 5/6] timens: keep the option off where the vDSO updates its own time data Eva Kurchatova
2026-10-19 0:16 ` no-reply
2026-10-20 16:13 ` Konstantin Khorenko
2026-10-19 0:05 ` [Devel] [PATCH hci-8.1 v2 6/6] config: follow the TIME_NS Kconfig change in config.vz10.minimal Eva Kurchatova
2026-10-19 0:16 ` no-reply
2026-10-20 16:13 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179251278950.3723285.3438661902523691061.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.